Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix components not properly closing when using the transition prop #3448

Merged
merged 5 commits into from
Sep 3, 2024
Merged

Fix components not properly closing when using the transition prop #3448

merged 5 commits into from
Sep 3, 2024

Commits on Sep 3, 2024

  1. add tests to verify that closing elements with transition prop works

    @RobinMalfait
    RobinMalfait committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    7d923a7 View commit details
    Browse the repository at this point in the history

  2. use local state for transitions 

    This now relies on local state for transitions so that when the local
state changes, the current component can re-render on its own already.
Relying on state from the parent via context, requires the full
component to re-render first which is not efficient enough for this
case.

We still need that more global state for cases where we want to
reference an element in another component (e.g.: reference the panel id
in a button's aria-controls attribute)
    @RobinMalfait
    RobinMalfait committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    c5c0682 View commit details
    Browse the repository at this point in the history

  3. update changelog

    @RobinMalfait
    RobinMalfait committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    2fbdc96 View commit details
    Browse the repository at this point in the history

  4. Update packages/@headlessui-react/CHANGELOG.md 

    Co-authored-by: Jonathan Reinink <[email protected]>
    @RobinMalfait @reinink
    RobinMalfait and reinink authored Sep 3, 2024
    Configuration menu
    Copy the full SHA
    40fff73 View commit details
    Browse the repository at this point in the history

  5. add comments why we track the value locally

    @RobinMalfait
    RobinMalfait committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    18d4509 View commit details
    Browse the repository at this point in the history