Fix issues spreading omitted props onto components #3313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
thecrypticace
force-pushed
the
fix/simplify-props-types
branch
from
27a79e8
to
1dca656
Compare
wip wip
thecrypticace
force-pushed
the
fix/simplify-props-types
branch
from
1dca656
to
9c0e44b
Compare
it’s no longer relevant
thecrypticace
changed the title
PropsForFeatures type
This was referenced Jul 27, 2024
This was referenced Aug 29, 2024
This was referenced Sep 6, 2024
This was referenced Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing
PropsForFeaturestype is meant to enable mutually exclusive props.A component may accept
staticandunmountbut may not accept both simultaneously. We encoded this in the typescript types but it's causing more problems than it solves. For example,Omit<ComponentProps, 'className'>can't be spread back onto the component.So this basically replaced the three cases with the following:
{ static?: boolean }{ unmount?: boolean }{ static?: boolean, unmount?: boolean }This makes TypeScript much happier about the types and should help typeschecking performance too.