Fix issues with scrolling in a virtual combobox #3163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
thecrypticace
commented
May 1, 2024
thecrypticace
commented
- If you open a combobox, select an option with the mouse (which closes it), and then reopen it does not scroll to the active option. This PR fixes this by resetting the internal "activation trigger" when the combobox closes.
- If you open a combobox, hover over an option, then press up/down to select the option above or below it, then scroll with the mouse wheel the combobox will not let you scroll past the currently active option. This PR fixes this by ensuring interactions with the scroll wheel count as "pointer" interactions which allows the list to scroll freely.
… was selected with the mouse
…ng options with keyboard
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This was referenced May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.