-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add string shorthand for the anchor
prop
#3133
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s by default This way simply adding `anchor="bottom"` to one of the anchorable components will also use these variables defined on the component.
+ CSS variables
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
RobinMalfait
changed the title
Implement
Implement Apr 24, 2024
anchor
API shorthandsanchor
API shorthand
RobinMalfait
force-pushed
the
feat/update-anchor-api
branch
from
April 24, 2024 21:30
ab16375
to
bd758b6
Compare
RobinMalfait
changed the title
Implement
Provide shorthand for the Apr 24, 2024
anchor
API shorthandanchor
prop
RobinMalfait
changed the title
Provide shorthand for the
Add string shorthand for the Apr 24, 2024
anchor
propanchor
prop
RobinMalfait
force-pushed
the
feat/update-anchor-api
branch
from
April 24, 2024 21:44
bd758b6
to
ec7c5b7
Compare
thecrypticace
approved these changes
Apr 24, 2024
This was referenced May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a shorthand for the
anchor
API. Theanchor
prop now accepts a string that maps to theanchor.to
property in the long-form object. Note: the long form object syntax is still supported.The
anchor.gap
,anchor.offset
andanchor.padding
options use CSS variables by default. They are defined asvar(--anchor-gap)
,var(--anchor-offset)
andvar(--anchor-padding)
respectively.This means that you can fully customize the anchor styles by setting CSS variables, for example via Tailwind classes.
An example using Tailwind CSS:
Which will render as: