Add optional onClose
callback to Combobox
component
#3122
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new optional
onClose
prop to theCombobox
component and it will be called when theCombobox
closes.Right now, we don't provide any information about why the
Combobox
closes, but that could be a future improvement.A good use case for this prop is if you want to reset some state that was used to filter the options, instead of resetting the state in multiple places such as an
onBlur
on theComboboxInput
or theonChange
of theCombobox
component itself.