Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move focus to ListboxOptions and MenuItems when they are rendered later #3112

Merged
merged 2 commits into from
Apr 19, 2024

Conversation

RobinMalfait
Copy link
Member

This PR fixes an issue where the focus is not properly moved to the ListboxOptions or MenuItems component if the underlying DOM node is rendered at a later point in time.

This can happen when the ListboxOptions or MenuItems component is rendered inside a Transition component.

Fixes: #3107

Copy link

vercel bot commented Apr 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
headlessui-react ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 19, 2024 4:34pm
headlessui-vue ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 19, 2024 4:34pm

Base automatically changed from fix/issue-3108 to main April 19, 2024 16:31
@RobinMalfait RobinMalfait merged commit dcbcd79 into main Apr 19, 2024
8 checks passed
@RobinMalfait RobinMalfait deleted the fix/issue-3107 branch April 19, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[insiders] Focus trapping broken with anchored, non-modal Listbox.Options inside Transition inside Dialog
2 participants