Change default tags for ListboxOptions
, ListboxOption
, ComboboxOptions
, ComboboxOption
and TabGroup
components
#3109
+6
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the default tags for the following components:
div
as default tag forListboxOptions
andListboxOption
componentsdiv
as default tag forComboboxOptions
andComboboxOption
componentsThese were using
ul
andli
respectively, which means that if you usedas="div"
on one of them, that you would have to useas="div"
on the other but that's not always clear and nothing will break or throw an error if you do. It would just be incorrect HTML.We already set a custom
role
attribute, so the default role we get fromul
/li
elements was overwritten anyway.div
as default tag forTabGroup
In a lot of places an additional wrapper element OR
as="div"
was requirement for layout such as constraining the width. Making theTabGroup
asdiv
by default will make it easier to do that.These are better defaults for these components for Headless UI v2.