Expose the --button-width CSS variable on the PopoverPanel component
#3058
+19
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently we require a `MutableRefObject<HTMLElement | null>`, but in some situations (Popover) we don't have a ref, but the direct element. This now supports passing in both. Another fix could be to wrap the raw value in a ref but that feels like an incorrect workaround.
This is necessary because jsdom doesn't implement `ResizeObserver` and then it would just crash.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
The `instanceof HTMLElement` cannot be used because this also runs on the server where `HTMLElement` is not available as a concrete class.
reinink
approved these changes
Mar 26, 2024
This was referenced May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR exposes the
--button-widthCSS variable on thePopoverPanelcomponent, similar to all are other components that accept ananchorprop.