Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forward disabled state to hidden inputs in form-like components #3004

Merged
merged 3 commits into from
Feb 21, 2024
Merged

Forward disabled state to hidden inputs in form-like components #3004

merged 3 commits into from
Feb 21, 2024

Conversation

RobinMalfait
Copy link
Member

This PR fixes an issue where form-like components are disabled then the hidden input fields should be disabled as well otherwise they will be submitted to the form.

We will now forward the disabled state to the hidden inputs.

Fixes: #2988

@vercel Vercel
Copy link

vercel bot commented Feb 21, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
headlessui-react ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 21, 2024 1:14pm
headlessui-vue ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 21, 2024 1:14pm

@RobinMalfait RobinMalfait changed the title Ensure hidden input fields are disabled main component is disabled Ensure hidden input fields are disabled, when the main component is disabled Feb 21, 2024
@RobinMalfait RobinMalfait changed the title Ensure hidden input fields are disabled, when the main component is disabled Forward disabled state to hidden inputs in form-like components Feb 21, 2024
@RobinMalfait RobinMalfait merged commit a50be92 into main Feb 21, 2024
8 checks passed
@RobinMalfait RobinMalfait deleted the fix/issue-2988 branch February 21, 2024 13:16
@RobinMalfait RobinMalfait mentioned this pull request Feb 21, 2024
Closed
RobinMalfait added a commit that referenced this pull request Apr 15, 2024
@RobinMalfait
Forward disabled state to hidden inputs in form-like components (#3004
2fd9d1c 
)

* make hidden inputs disabled if the wrapping component is disabled

* add tests to verify disabled hidden form elements

* update changelog
This was referenced May 18, 2024
Closed
Closed
Closed
@michael-moussaoui michael-moussaoui mentioned this pull request May 20, 2024
Open
This was referenced May 21, 2024
Closed
Closed
Closed
@ishaan-jaff ishaan-jaff mentioned this pull request May 24, 2024
Open
@nejidevelops nejidevelops mentioned this pull request May 24, 2024
Open
@philpotisk philpotisk mentioned this pull request May 25, 2024
Closed
@Jeb4dev Jeb4dev mentioned this pull request May 25, 2024
Closed
@ha404 ha404 mentioned this pull request May 25, 2024
Open
@Jeb4dev Jeb4dev mentioned this pull request May 26, 2024
Closed
@Jeb4dev Jeb4dev mentioned this pull request May 26, 2024
Closed
@JMARRUJO91 JMARRUJO91 mentioned this pull request May 27, 2024
Closed
@gr00nd gr00nd mentioned this pull request May 28, 2024
Open
@Jeb4dev Jeb4dev mentioned this pull request May 28, 2024
Closed
This was referenced May 28, 2024
Open
Open
@Jeb4dev Jeb4dev mentioned this pull request May 29, 2024
Closed
@JMARRUJO91 JMARRUJO91 mentioned this pull request May 29, 2024
Closed
@gr00nd gr00nd mentioned this pull request May 29, 2024
Open
@Jeb4dev Jeb4dev mentioned this pull request May 30, 2024
Closed
@JMARRUJO91 JMARRUJO91 mentioned this pull request May 30, 2024
Open
This was referenced May 31, 2024
Closed
Open
@philpotisk philpotisk mentioned this pull request Jun 2, 2024
Closed
@Jeb4dev Jeb4dev mentioned this pull request Jun 2, 2024
Open
@Artur-data-DEV Artur-data-DEV mentioned this pull request Jun 5, 2024
Open
@iamsatyanchal iamsatyanchal mentioned this pull request Jun 5, 2024
Open
@thierry-laval thierry-laval mentioned this pull request Jun 6, 2024
Open
@gr00nd gr00nd mentioned this pull request Jun 15, 2024
Open
This was referenced Jun 18, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Combobox disabled attribute not disabling hidden inputs
1 participant
@RobinMalfait