[v2] Attempt form submission when pressing Enter on Checkbox component
#2962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
reinink
changed the title
Enter on Checkbox componentEnter on Checkbox component
This was referenced May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where pressing
Enteron a<Checkbox />component didn't attempt to submit the form. This PR solves that.The
Checkboxcomponent is aspanto make it stylable which means that it doesn't have the native capabilities to submit a form (we do render a hidden input field for exposing the data to the parentformbut it doesn't retrieve any events directly).This now implements the same logic as the
<Switch />component where it attempts to submit the form.Fixes: #2958