fix: double onClose on mobile dialog outClick #2690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@DavideFrancescon Hey, thanks for opening this! Could you enable maintainer access for the PR? |
|
@thecrypticace Should have invited you! Thanks for the fast response |
|
That works, thanks! For future reference though you don't have to invite people for that. There's a checkbox in the right sidebar at the bottom when you open a PR to enable maintainer access. It looks like this: 
Afaik, this ensures the access is only temporary while the PR is open. |
|
Merged. Thanks! This will be in the insiders build until we push a new release out. Probably later this week. There's a few more fixes I want to get in if I can. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #2671
Removed click event on mobile that was fired before onTouchEnd causing a the onClose function to fire twice.