Fix incorrectly focused Combobox.Input component on page load
#2654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
RobinMalfait
changed the title
Combobox.Input on page loadCombobox.Input on page load
RobinMalfait
changed the title
Combobox.Input on page loadCombobox.Input component on page load
RobinMalfait
force-pushed
the
fix/issue-2653
branch
from
3919d99 to
48ed332
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an odd issue in the
Comboboxwhere it incorrectly focuses theCombobox.Input.We have some code that ensures that the selection range of the
Combobox.Inputis correct when syncing values to the input field. However, callingsetSelectionRangewill actually focus theinputDOM element if it is not focused yet.This PR will only try to set the selection range if the input is the focused element.
Fixes: #2653