Fix change event incorrectly getting called on blur
#2296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was only used in tests and doesn't seem to be necessary.
This only emitted a `change` event, which Vue already emits as well.
This is an odd one. In Chrome this means that the `@change` is still being called, but if we keep it, then the `@change` is _also_ called on blur resulting in odd bugs. Droping it fixes that issue. That said, the `@change` is _still_ emitted and therefore the callback is properly called and the `ComboboxInput` still can interact with the `@change` event.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
RobinMalfait
changed the title
change event incorrectly getting called on blurchange event incorrectly getting called on blur
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an odd bug where blurring the input field would call the
@changeevent on theComboboxInput, this ins turn sets thequery.valueand therefore a list of data would be (incorrectly) filtered again because we expectedquery.value === ''.Internally we set the
onChangeto a handler that just re-emitted thechangeevent, but Vue already does that for you.Fixes: #2171