Fix crash when children
are undefined
#1885
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where if you render no children at all (probably user error because all our components require at least some form of child) the component crashes with an error. This PR ensures that
children
are always an error so that the issue should not occur anymore.That said, if you just render something like:
It won't crash anymore, but it will also not work as expected since the
MenuButton
,MenuItems
andMenuItem
components are missing.Fixes: #1884