Fix use of undefined
and displayValue
in Combobox
#1865
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the combobox box is given a v-model ref that is
undefined
we do not calldisplayValue
and can end up displaying the stringundefined
. This is actually a bug in Vue itself (vuejs/core#5032) but we can work around this by passing a dummy ref that has a defined value. This allowsimmediate
to work as expected.Fixes #1861