Ensure we handle the static prop in Tab.Panel components correctly
#1856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
RobinMalfait
force-pushed
the
fix/issue-1323
branch
from
45b8492
to
c1707ea
Compare
RobinMalfait
changed the title
static Tab.Panel correctlystatic prop in Tab.Panel components correctly
RobinMalfait
force-pushed
the
fix/issue-1323
branch
from
c1707ea
to
7644794
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where
staticTab Panels didn't take thestaticprop into account whenrendering the "hidden" panel (to guarantee tab order and matching tab panels).
Fixes: tailwindlabs/tailwindui-issues#1323