Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure Tab order stays consistent, and the currently active Tab stays active #1837

Merged
merged 3 commits into from
Sep 8, 2022
Merged

Ensure Tab order stays consistent, and the currently active Tab stays active #1837

merged 3 commits into from
Sep 8, 2022

Commits on Sep 8, 2022

  1. ensure tabs order stays consistent 

    This ensures that whenever you insert or delete tabs before the current
tab, that the current tab stays active with the proper panel.

To do this we had to start rendering the non-visible panels as well, but
we used the `Hidden` component already which is position fixed and
completely hidden so this should not break layouts where using flexbox
or grid.
    @RobinMalfait
    RobinMalfait committed Sep 8, 2022
    Configuration menu
    Copy the full SHA
    9cad457 View commit details
    Browse the repository at this point in the history

  2. update changelog

    @RobinMalfait
    RobinMalfait committed Sep 8, 2022
    Configuration menu
    Copy the full SHA
    0456bda View commit details
    Browse the repository at this point in the history

  3. fix TypeScript issue

    @RobinMalfait
    RobinMalfait committed Sep 8, 2022
    Configuration menu
    Copy the full SHA
    9992f09 View commit details
    Browse the repository at this point in the history