Fix Transition component's incorrect cleanup and order of events
#1803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
If anything is still wrong the tests will still fail but the diffs will be easier to read.
RobinMalfait
force-pushed
the
fix/transition-issues
branch
from
88c1fd8
to
e77d621
Compare
RobinMalfait
changed the title
Transition componentTransition component's incorrect cleanup and order of events
RobinMalfait
force-pushed
the
fix/transition-issues
branch
from
488312c
to
fb2c4cc
Compare
RobinMalfait
changed the title
Transition component's incorrect cleanup and order of events Transition component's incorrect cleanup and order of events
RobinMalfait
force-pushed
the
fix/transition-issues
branch
from
fb2c4cc
to
df76ef0
Compare
RobinMalfait
force-pushed
the
fix/transition-issues
branch
from
df76ef0
to
1b8a10b
Compare
RobinMalfait
force-pushed
the
fix/transition-issues
branch
from
1b8a10b
to
ec05b37
Compare
We will get back to these!
RobinMalfait
force-pushed
the
fix/transition-issues
branch
from
ec05b37
to
bf3cab3
Compare
This was referenced Sep 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should fix a handful of issues where
leavetransitions weren't properly cleaning upthe DOM resulting in sometimes UI pages that feel "stuck", especially if you are using a
Dialogcomponent that is technically still open now due to incorrect unmounting.
A lot of the
Dialogcomponents usefixed inset-0which renders a div for the backdrop but sincethat is sometimes still there and sitting on top of all other content, this results in the stuck
pages.
This PR should improve that, and therefore also fix some open issues:
Fixes: #1557
Fixes: #1638
Fixes: #1364
Closes: #1585 (this is a big, but incomplete rewrite of the
Transitioncomponent; We can pick this up later if needed)