Support <slot> children when using as="template"
#1548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
thecrypticace
changed the title
<slot> as a child when using as="template"<slot> children when using as="template"
thecrypticace
force-pushed
the
fix/render-with-slots
branch
from
cea376f to
820bdb8
Compare
thecrypticace
force-pushed
the
fix/render-with-slots
branch
from
820bdb8 to
472643f
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many of the elements in Headless UI allow you to render fragments/templates but we will still modify the VNode that's inside it. This did not work in the case of
<slot>because the placeholder isn't an actual element. We now resolve these internally before rendering and will still detect if the slot doesn't have a valid element that we can use.We also handle this nesting recursively so there shouldn't be any problem with multiple levels of nesting with components that all use
<slot>s.Fixes #485