Ensure the the <Popover.Panel focus> closes correctly
#1477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where the
Popover.Panelisn't closed correctly if you are using thefocusprop. This is because the idea behind thefocusflag is that when thePopover.Panelopens the focus is moved inside thePopover.Panel. If the focus is moved outside of thePopover.Panelthen thePopover.Panelwill close again.The issue with this is that the moment you click the
Popover.Buttonwhen thePopoveris open thethe following happens:
Popover.Button.Popoverwill close due to the above.Popover.Button.Popoveragain.This means that you can't close is anymore via click. This PR fixes that issue.
Fixes: #1342