Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explicit multiple prop #1355

Merged
merged 4 commits into from
Apr 22, 2022
Merged

Add explicit multiple prop #1355

merged 4 commits into from
Apr 22, 2022

Conversation

RobinMalfait
Copy link
Member

@RobinMalfait RobinMalfait commented Apr 22, 2022

This PR requires you to explicitly set the multiple prop on the Listbox & Combobox components if you want multi-value support.

This is required if you want to set the value to a tuple in single-value mode, which was not possible before the multiple prop was introduced, because then it resulted in multi-value mode instead of single-value mode.


NOTE: If you are using the insiders build AND you are using multiple values, then this will be a breaking change for you. Add the multiple prop to your Listbox and Combobox components that require multi value support and you should be good to go!

@vercel
Copy link

vercel bot commented Apr 22, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
headlessui-react ✅ Ready (Inspect) Visit Preview Apr 22, 2022 at 4:49PM (UTC)
headlessui-vue ✅ Ready (Inspect) Visit Preview Apr 22, 2022 at 4:49PM (UTC)

This allows you to set the value to a **tuple** in `single-value` mode,
which was not possible before the `multiple` prop was introduced,
because then it resulted in `multi-value` mode instead of `single-value`
mode.
This allows you to set the value to a **tuple** in `single-value` mode,
which was not possible before the `multiple` prop was introduced,
because then it resulted in `multi-value` mode instead of `single-value`
mode.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant