Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves upon this PR: #1181
In that PR we ignored syncing when your value was set to
undefined
, that means that if you "reset" your value toundefined
that the old value was still present in the Input. To fix this, we will always sync (unless we don't have an input field).This means that your
displayValue
should always return something. It could happen that you have to write this:(React example)
This would have resulted in
"undefined"
in the input, so we will also make sure thatnull
andundefined
values are converted to an empty string (''
). It's important that we use?? ''
and not|| ''
, otherwise values like0
would be converted to an empty string as well.