Fix Dialog usage in Tabs #1149
Merged
Fix Dialog usage in Tabs #1149
+2
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently we are collecting the `restoreElement` even if the focus trap is not enabled. When we unmount we try to restore it. The problem is the moment you unmount you want to restore but only if the focus trap was enabled. Another issue is that the dialog state will be `closed` before we get to the `onUmount` hook. So there is probably a cleaner way to fix this, but this does the trick as well where we only record the restoreElement the moment the focus trap gets enabled.
|
This pull request is being automatically deployed with Vercel (learn more). headlessui-vue – ./packages/playground-vue🔍 Inspect: https://vercel.com/tailwindlabs/headlessui-vue/CadjjbPUHVLnEuapDBZsBfp5eLL9 headlessui-react – ./packages/playground-react🔍 Inspect: https://vercel.com/tailwindlabs/headlessui-react/DMU15hcoqk1qmt3Cz3tdF1Gf3vgW |
RobinMalfait
changed the title
RobinMalfait
force-pushed
the
ensure-tabs-and-dialog-work-together
branch
from
b4bd661 to
84bc5c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initially I thought that our open/closed internal state was conflicting between the Tab and Dialog. But that isn't the case at all.
The issue is in the focus trap currently we are collecting the
restoreElementeven if the focus trap is not enabled. When we unmount we try to restore it.The problem is the moment you unmount you want to restore but only if the focus trap was enabled.
Another issue is that the dialog state will be
closedbefore we get to theonUmounthook. So there is probably a cleaner way to fix this, but this does the trick as well where we only record the restoreElement the moment the focus trap gets enabled.Fixes: #1100