Bubble Escape event even if Combobox.Options
is not rendered at all
#1104
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you use
<Combobox.Options static />
it means that you are incontrol of rendering and in that case we also bubble the
Escape
because you are in control of it.
However, if you do something like this:
Then whenever the
filteredList
is empty, the Combobox.Options are notrendered at all which means that we can't look at the
static
prop. Tofix this, we also bubble the
Escape
event if we don't have aCombobox.Options
at all so that the above example works as expected.