-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: In the dialog form when submitting, it is not submitted #451
Comments
I am seeing this issue with @headlessui/react as well |
I also ran into this problem with @headlessui/react |
Seems similar to an issue i'm having where 'a' tags and input type="file" clicks aren't working either. Looks like an event listener on the 'Dialog' component is consuming the click events. Downgrading back to v1.0.0 for now... |
Here's a code sandbox reproduction https://codesandbox.io/s/headless-ui-dialog-forked-fi34g?file=/src/Modal.tsx |
I was wondering what was going on. I just updated to 1.1.0 yesterday, and just tested the form in a dialog today. Ha! I downgraded to 1.0.0, for now, until a fix is implemented. |
* fix clicks and form submissions in Dialog component Fixes: #451 * update changelog
Hey! Thank you for your bug report! Sorry about that! Should be fixed in 1.1.1 |
I delete the repository, but I attach the two branches. |
Thanks for the fix! just adding some keywords for anyone hitting this issue: link modal dialog broken not working click event propagation events swallowed |
What package within Headless UI are you using?
@headlessui/vue
What version of that package are you using?
v1.1.0
What browser are you using?
Chrome
Reproduction repository
https://github.com/dacoto97/broken_headlessui/tree/updated_to_1.1.0
Describe your issue
When updating to headlessui 1.1.0 the forms do not send with the submint button, see the changes: https://github.com/dacoto97/broken_headlessui/pull/1
You can see how the main branch does work, but when you switch to the update branch dosn't work the submit.
Main: https://github.com/dacoto97/broken_headlessui/tree/main
Update branch: https://github.com/dacoto97/broken_headlessui/tree/updated_to_1.1.0
The text was updated successfully, but these errors were encountered: