Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: In the dialog form when submitting, it is not submitted #451

Closed
dacoto97 opened this issue Apr 26, 2021 · 8 comments
Closed

[Bug]: In the dialog form when submitting, it is not submitted #451

dacoto97 opened this issue Apr 26, 2021 · 8 comments

Comments

@dacoto97
Copy link

What package within Headless UI are you using?

@headlessui/vue

What version of that package are you using?

v1.1.0

What browser are you using?

Chrome

Reproduction repository

https://github.com/dacoto97/broken_headlessui/tree/updated_to_1.1.0

Describe your issue

When updating to headlessui 1.1.0 the forms do not send with the submint button, see the changes: https://github.com/dacoto97/broken_headlessui/pull/1
You can see how the main branch does work, but when you switch to the update branch dosn't work the submit.
Main: https://github.com/dacoto97/broken_headlessui/tree/main
Update branch: https://github.com/dacoto97/broken_headlessui/tree/updated_to_1.1.0

@anark
Copy link

anark commented Apr 26, 2021

I am seeing this issue with @headlessui/react as well

@timurmaio
Copy link

timurmaio commented Apr 27, 2021

I also ran into this problem with @headlessui/react

@Nazaire
Copy link

Nazaire commented Apr 28, 2021

Seems similar to an issue i'm having where 'a' tags and input type="file" clicks aren't working either. Looks like an event listener on the 'Dialog' component is consuming the click events. Downgrading back to v1.0.0 for now...

@hailwood
Copy link
Contributor

@nickroberts
Copy link

I was wondering what was going on. I just updated to 1.1.0 yesterday, and just tested the form in a dialog today. Ha!

I downgraded to 1.0.0, for now, until a fix is implemented.

RobinMalfait added a commit that referenced this issue Apr 28, 2021
* fix clicks and form submissions in Dialog component

Fixes: #451

* update changelog
@RobinMalfait
Copy link
Member

Hey! Thank you for your bug report!
Much appreciated! 🙏

Sorry about that! Should be fixed in 1.1.1

@dacoto97
Copy link
Author

I delete the repository, but I attach the two branches.
MAIN: broken_headlessui-main.zip
BROKEN: broken_headlessui-updated_to_1.1.0.zip

@denu5
Copy link

denu5 commented May 11, 2021

Thanks for the fix!
Stumbling over this in a next.js project was painful, since the internal nextjs link components work.

just adding some keywords for anyone hitting this issue:

link modal dialog broken not working click event propagation events swallowed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants