Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Menu is broken #267

Closed
nagbg opened this issue Mar 2, 2021 · 3 comments
Closed

Menu is broken #267

nagbg opened this issue Mar 2, 2021 · 3 comments
Assignees
@RobinMalfait
Labels
bug Something isn't working

Comments

@nagbg
Copy link

nagbg commented Mar 2, 2021

In the latent version of vue the components are broken. Even on the demo page the menu doesn’t open on click. In my own build it opens but active state on hover or keyboard navigation does not work.
@nagbg
Copy link
Author

nagbg commented Mar 3, 2021

Hi @RobinMalfait!

Found out it's breaking after Vue 3.0.5.

@RobinMalfait
Copy link
Member

Hey! Thank you for your bug report!
Much appreciated! 🙏

Very odd that this starts happening randomly after a some patch updates 🤔
I'm going to investigate this and report back!

@RobinMalfait RobinMalfait self-assigned this Mar 5, 2021
@RobinMalfait RobinMalfait added the bug Something isn't working label Mar 5, 2021
RobinMalfait added a commit that referenced this issue Mar 15, 2021
@RobinMalfait
fix event name casing
26f2b42 
Vue broke this in a 3.0.5 release, it still worked in 3.0.4.

Fixes: #267
RobinMalfait added a commit that referenced this issue Mar 15, 2021
@RobinMalfait
fix event name casing
70459c6 
Vue broke this in a 3.0.5 release, it still worked in 3.0.4.

Fixes: #267
RobinMalfait added a commit that referenced this issue Mar 15, 2021
@RobinMalfait
Vue breaking change (#279)
4648332 
* bump Vue

* ensure we reference the vite.config.js

* fix event name casing

Vue broke this in a 3.0.5 release, it still worked in 3.0.4.

Fixes: #267

* handle throwing while rendering a better in tests
@RobinMalfait
Copy link
Member

This should be fixed, and will be available in the next release.
You can already try it using npm install @headlessui/vue@dev or yarn add @headlessui/vue@dev.

Relevant PR: #279

RobinMalfait added a commit that referenced this issue Mar 22, 2021
@RobinMalfait
Vue breaking change (#279)
6ba0337 
* bump Vue

* ensure we reference the vite.config.js

* fix event name casing

Vue broke this in a 3.0.5 release, it still worked in 3.0.4.

Fixes: #267

* handle throwing while rendering a better in tests
RobinMalfait added a commit that referenced this issue Mar 26, 2021
@RobinMalfait
Vue breaking change (#279)
0697417 
* bump Vue

* ensure we reference the vite.config.js

* fix event name casing

Vue broke this in a 3.0.5 release, it still worked in 3.0.4.

Fixes: #267

* handle throwing while rendering a better in tests
RobinMalfait added a commit that referenced this issue Apr 2, 2021
@RobinMalfait
Vue breaking change (#279)
9ba2980 
* bump Vue

* ensure we reference the vite.config.js

* fix event name casing

Vue broke this in a 3.0.5 release, it still worked in 3.0.4.

Fixes: #267

* handle throwing while rendering a better in tests
RobinMalfait added a commit that referenced this issue Apr 2, 2021
@RobinMalfait
backfill fixes (#299)
5da253b 
* fix unique symbol error (#248)

* Vue breaking change (#279)

* bump Vue

* ensure we reference the vite.config.js

* fix event name casing

Vue broke this in a 3.0.5 release, it still worked in 3.0.4.

Fixes: #267

* handle throwing while rendering a better in tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RobinMalfait RobinMalfait

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@RobinMalfait @nagbg