Skip to content

Commit

Permalink
Fix unique symbol error (#248)
Browse files Browse the repository at this point in the history
* replace unique symbol with uuid v4

Ideally we can use a Symbol, however it seems that TypeScript or TSDX,
inlines the `unique symbol`, instead of referencing the actual __
placeholder type.

Ideally we add this back in the future, but the odds that somebody has
this specific uuid in production is close to 0. (Unless they
specifically use this uuid).

Fixes: #240

Thanks to =?UTF-8?q?Micha=C3=ABl=20Zasso?= <[email protected]> for
providing a reproduction repository!

* update changelog
  • Loading branch information
RobinMalfait committed Apr 2, 2021
1 parent 9fad9ef commit 4a02a5c
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

- Fixed `outside click` not re-focusing the `Menu.Button` ([#220](https://github.com/tailwindlabs/headlessui/pull/220))
- Fixed `outside click` not re-focusing the `Listbox.Button` ([#220](https://github.com/tailwindlabs/headlessui/pull/220))
- Fix incorrect type error `unique symbol` ([#248](https://github.com/tailwindlabs/headlessui/pull/248), [#240](https://github.com/tailwindlabs/headlessui/issues/240))

### Added

Expand Down

0 comments on commit 4a02a5c

Please sign in to comment.