ensure Switch has type="button" (#192)

Closes: #178 Co-authored-by: =?UTF-8?q?Oskar=20L=C3=B6fgren?= <[email protected]> Co-authored-by: =?UTF-8?q?Oskar=20L=C3=B6fgren?= <[email protected]>
tailwindlabs · Jan 8, 2021 · 17a8535 · 17a8535
1 parent e941c70
commit 17a8535
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/packages/@headlessui-react/src/components/switch/switch.tsx b/packages/@headlessui-react/src/components/switch/switch.tsx
@@ -117,6 +117,10 @@ export function Switch<TTag extends React.ElementType = typeof DEFAULT_SWITCH_TA
     onKeyPress: handleKeyPress,
   }
 
+  if (passThroughProps.as === 'button') {
+    Object.assign(propsWeControl, { type: 'button' })
+  }
+
   return render({ ...passThroughProps, ...propsWeControl }, propsBag, DEFAULT_SWITCH_TAG)
 }
 

diff --git a/packages/@headlessui-vue/src/components/switch/switch.ts b/packages/@headlessui-vue/src/components/switch/switch.ts
@@ -74,6 +74,10 @@ export const Switch = defineComponent({
       onKeyPress: this.handleKeyPress,
     }
 
+    if (this.$props.as === 'button') {
+      Object.assign(propsWeControl, { type: 'button' })
+    }
+
     return render({
       props: { ...this.$props, ...propsWeControl },
       slot,