Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create Z.scala #73

Closed
wants to merge 1 commit into from
Closed

Create Z.scala #73

wants to merge 1 commit into from

Conversation

amitkumarj441
Copy link
Member

Initialized Z to run algorithm #67 #64

@amitkumarj441
Create Z.scala
48ebb7b 
Initialized Z to run algorithm
mandar2812
mandar2812 requested changes Mar 9, 2017
View reviewed changes
Copy link
Member

@mandar2812 mandar2812 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs scala doc and normal commenting. Please explain the choice of class name Z. If this refers to the partition function constant in sampling then fine, but the class name can still be made more informative.

@mandar2812 mandar2812 closed this Dec 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mandar2812 mandar2812 mandar2812 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amitkumarj441 @mandar2812