feat: create @call operator
#881
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #881 +/- ##
==========================================
- Coverage 88.39% 82.80% -5.60%
==========================================
Files 99 100 +1
Lines 10721 11000 +279
==========================================
- Hits 9477 9108 -369
- Misses 1244 1892 +648 ☔ View full report in Codecov by Sentry. |
ologbonowiwi
commented
Jan 3, 2024
ologbonowiwi
commented
Jan 3, 2024
ologbonowiwi
commented
Jan 3, 2024
meskill
reviewed
Jan 3, 2024
ologbonowiwi
force-pushed
the
feat/#846/create-call-operator
branch
from
0d5a205 to
b0d82b0
Compare
ologbonowiwi
commented
Jan 3, 2024
…allhq#846/create-call-operator
# Conflicts: # src/config/from_document.rs # tests/graphql/errors/test-multiple-resolvable-directives-on-field.graphql
|
The serialization counterpart of this is missing from |
…allhq#846/create-call-operator
…:ologbonowiwi/tailcall into feat/tailcallhq#846/create-call-operator
|
fixed, thank you @mogery |
ologbonowiwi
commented
Jan 29, 2024
Comment on lines
+36
to
+92
| struct Http { | ||
| pub req_template: http::RequestTemplate, | ||
| pub group_by: Option<GroupBy>, | ||
| pub dl_id: Option<DataLoaderId>, | ||
| } | ||
|
|
||
| struct GraphQLEndpoint { | ||
| pub req_template: graphql::RequestTemplate, | ||
| pub field_name: String, | ||
| pub batch: bool, | ||
| pub dl_id: Option<DataLoaderId>, | ||
| } | ||
|
|
||
| struct Grpc { | ||
| pub req_template: grpc::RequestTemplate, | ||
| pub group_by: Option<GroupBy>, | ||
| pub dl_id: Option<DataLoaderId>, | ||
| } | ||
|
|
||
| impl TryFrom<Expression> for Http { | ||
| type Error = String; | ||
|
|
||
| fn try_from(expr: Expression) -> Result<Self, Self::Error> { | ||
| match expr { | ||
| Expression::IO(IO::Http { req_template, group_by, dl_id }) => { | ||
| Ok(Http { req_template, group_by, dl_id }) | ||
| } | ||
| _ => Err("not an http expression".to_string()), | ||
| } | ||
| } | ||
| } | ||
|
|
||
| impl TryFrom<Expression> for GraphQLEndpoint { | ||
| type Error = String; | ||
|
|
||
| fn try_from(expr: Expression) -> Result<Self, Self::Error> { | ||
| match expr { | ||
| Expression::IO(IO::GraphQLEndpoint { req_template, field_name, batch, dl_id }) => { | ||
| Ok(GraphQLEndpoint { req_template, field_name, batch, dl_id }) | ||
| } | ||
| _ => Err("not a graphql expression".to_string()), | ||
| } | ||
| } | ||
| } | ||
|
|
||
| impl TryFrom<Expression> for Grpc { | ||
| type Error = String; | ||
|
|
||
| fn try_from(expr: Expression) -> Result<Self, Self::Error> { | ||
| match expr { | ||
| Expression::IO(IO::Grpc { req_template, group_by, dl_id }) => { | ||
| Ok(Grpc { req_template, group_by, dl_id }) | ||
| } | ||
| _ => Err("not a grpc expression".to_string()), | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
This was done to avoid unreachable code. I can delete it and use match letting an unreachable _ => Valid::succeed or _ => panic!, let me know which is better, guys.
|
I'll open another one. This had many outdated discussions, which makes harder to follow and review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Reference(s):
Fixes #846
/claim #846
Build & Testing:
cargo testsuccessfully../lint.sh --mode=fixto fix all linting issues raised by./lint.sh --mode=check.Checklist:
<type>(<optional scope>): <title>