Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: drop support for json yaml from Config #3201

Merged
merged 11 commits into from
Dec 9, 2024

Conversation

meskill
Copy link
Contributor

@meskill meskill commented Dec 5, 2024

Summary:
Briefly describe the changes made in this PR.

Issue Reference(s):
Fixes #... (Replace "..." with the issue number)

Build & Testing:

  • I ran cargo test successfully.
  • I have run ./lint.sh --mode=fix to fix all linting issues raised by ./lint.sh --mode=check.

Checklist:

  • I have added relevant unit & integration tests.
  • I have updated the documentation accordingly.
  • I have performed a self-review of my code.
  • PR follows the naming convention of <type>(<optional scope>): <title>

@github-actions github-actions bot added the type: chore Routine tasks like conversions, reorganization, and maintenance work. label Dec 5, 2024
Copy link

codecov bot commented Dec 5, 2024

Codecov Report

Attention: Patch coverage is 91.17647% with 3 lines in your changes missing coverage. Please review.

Project coverage is 86.66%. Comparing base (858ac97) to head (30691fd).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/core/config/config.rs 57.14% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3201      +/-   ##
==========================================
- Coverage   86.75%   86.66%   -0.09%     
==========================================
  Files         278      278              
  Lines       27963    27932      -31     
==========================================
- Hits        24258    24206      -52     
- Misses       3705     3726      +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tusharmath tusharmath marked this pull request as draft December 6, 2024 18:05
@tusharmath tusharmath marked this pull request as ready for review December 8, 2024 18:52
laststylebender14 and others added 8 commits December 8, 2024 11:55
Co-authored-by: blacksmith-sh[bot] <157653362+blacksmith-sh[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Tushar Mathur <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@tusharmath tusharmath changed the title refactor: drop support for json/yaml configs feat: drop support for json/yaml configs Dec 8, 2024
@tusharmath tusharmath changed the title feat: drop support for json/yaml configs feat: drop support for json yaml from Config Dec 8, 2024
@tusharmath tusharmath added the release: breaking Introduces a breaking change. label Dec 8, 2024
# Conflicts:
#	generated/.tailcallrc.schema.json
@github-actions github-actions bot added the type: feature Brand new functionality, features, pages, workflows, endpoints, etc. label Dec 8, 2024
@tusharmath tusharmath enabled auto-merge (squash) December 9, 2024 07:45
@tusharmath tusharmath merged commit 01ebf87 into main Dec 9, 2024
30 of 31 checks passed
@tusharmath tusharmath deleted the refactor/drop-json-yaml-support branch December 9, 2024 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: breaking Introduces a breaking change. type: chore Routine tasks like conversions, reorganization, and maintenance work. type: feature Brand new functionality, features, pages, workflows, endpoints, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants