Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support multiple resolvers on fields #3124

Merged
merged 21 commits into from
Nov 27, 2024
Merged

Conversation

meskill
Copy link
Contributor

@meskill meskill commented Nov 19, 2024

Summary:
Briefly describe the changes made in this PR.

Issue Reference(s):
Fixes #3120

Build & Testing:

  • I ran cargo test successfully.
  • I have run ./lint.sh --mode=fix to fix all linting issues raised by ./lint.sh --mode=check.

Checklist:

  • I have added relevant unit & integration tests.
  • I have updated the documentation accordingly.
  • I have performed a self-review of my code.
  • PR follows the naming convention of <type>(<optional scope>): <title>

@github-actions github-actions bot added the type: feature Brand new functionality, features, pages, workflows, endpoints, etc. label Nov 19, 2024
@meskill meskill changed the title Feat/multiple-resolvers Support multiple resolvers on fields Nov 23, 2024
@meskill meskill changed the title Support multiple resolvers on fields feat: support multiple resolvers on fields Nov 23, 2024
@meskill meskill marked this pull request as ready for review November 23, 2024 13:33
Copy link

codecov bot commented Nov 23, 2024

Codecov Report

Attention: Patch coverage is 94.89051% with 21 lines in your changes missing coverage. Please review.

Project coverage is 86.73%. Comparing base (d053a88) to head (8c5a7b4).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/core/config/resolver.rs 67.50% 13 Missing ⚠️
src/core/config/transformer/subgraph.rs 72.72% 3 Missing ⚠️
src/core/merge_right.rs 97.27% 3 Missing ⚠️
src/cli/tc/init.rs 0.00% 1 Missing ⚠️
src/core/ir/eval.rs 98.46% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3124      +/-   ##
==========================================
+ Coverage   86.69%   86.73%   +0.04%     
==========================================
  Files         275      276       +1     
  Lines       27319    27493     +174     
==========================================
+ Hits        23683    23845     +162     
- Misses       3636     3648      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

# Conflicts:
#	src/core/jit/transform/auth_planer.rs
@tusharmath
Copy link
Contributor

@meskill Thanks! This is a great PR. We need to update the docs for each directive here — https://tailcall.run/docs/tailcall-dsl-graphql-custom-directives/

@tusharmath tusharmath marked this pull request as draft November 25, 2024 00:51
@meskill
Copy link
Contributor Author

meskill commented Nov 25, 2024

@meskill Thanks! This is a great PR. We need to update the docs for each directive here — https://tailcall.run/docs/tailcall-dsl-graphql-custom-directives/

added documentation here tailcallhq/tailcallhq.github.io#560

@meskill meskill marked this pull request as ready for review November 25, 2024 17:50
@tusharmath tusharmath enabled auto-merge (squash) November 27, 2024 08:12
@tusharmath tusharmath disabled auto-merge November 27, 2024 21:08
@tusharmath tusharmath merged commit f32ab51 into main Nov 27, 2024
10 checks passed
@tusharmath tusharmath deleted the feat/multiple-resolvers branch November 27, 2024 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature Brand new functionality, features, pages, workflows, endpoints, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support multiple resolvers on fields
3 participants