Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add dedupe capability on all IO operations #2945

Merged
merged 27 commits into from
Oct 1, 2024
Merged

Conversation

ssddOnTop
Copy link
Member

Issue Reference(s):
Fixes #2893

@ssddOnTop ssddOnTop added the ci: benchmark Runs benchmarks label Sep 30, 2024
@github-actions github-actions bot added the type: chore Routine tasks like conversions, reorganization, and maintenance work. label Sep 30, 2024
Copy link

codecov bot commented Sep 30, 2024

Codecov Report

Attention: Patch coverage is 99.23664% with 1 line in your changes missing coverage. Please review.

Project coverage is 87.49%. Comparing base (cec5896) to head (bb028c5).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/core/jit/graphql_executor.rs 98.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2945      +/-   ##
==========================================
+ Coverage   87.44%   87.49%   +0.04%     
==========================================
  Files         263      263              
  Lines       26428    26523      +95     
==========================================
+ Hits        23109    23205      +96     
+ Misses       3319     3318       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Sep 30, 2024

🐰 Bencher Report

Branch2945/merge
Testbedbenchmarking-runner
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
nanoseconds (ns)
(Result Δ%)
Upper Boundary
nanoseconds (ns)
(Limit %)
from_json_bench📈 view plot
🚷 view threshold
6,249,600.00
(+0.68%)
6,366,473.06
(98.16%)
group_by📈 view plot
🚷 view threshold
485.13
(-1.01%)
512.70
(94.62%)
input/args.missing📈 view plot
🚷 view threshold
25.23
(-1.85%)
28.03
(90.00%)
input/args.nested.existing📈 view plot
🚷 view threshold
44.76
(-1.68%)
48.39
(92.49%)
input/args.nested.missing📈 view plot
🚷 view threshold
38.15
(-1.31%)
40.95
(93.16%)
input/args.root📈 view plot
🚷 view threshold
40.58
(-1.91%)
45.02
(90.12%)
input/headers.existing📈 view plot
🚷 view threshold
32.84
(+3.72%)
34.17
(96.11%)
input/headers.missing📈 view plot
🚷 view threshold
32.13
(+4.42%)
33.57
(95.71%)
input/value.missing📈 view plot
🚷 view threshold
23.47
(+0.18%)
24.64
(95.26%)
input/value.nested.existing📈 view plot
🚷 view threshold
42.72
(-0.93%)
45.76
(93.35%)
input/value.nested.missing📈 view plot
🚷 view threshold
36.34
(-0.30%)
38.30
(94.90%)
input/value.root📈 view plot
🚷 view threshold
39.88
(+2.62%)
41.99
(94.96%)
input/vars.existing📈 view plot
🚷 view threshold
8.52
(+3.20%)
9.54
(89.34%)
input/vars.missing📈 view plot
🚷 view threshold
11.62
(+21.93%)
12.77
(91.05%)
synth_nested📈 view plot
🚷 view threshold
135,110.00
(+22.06%)
159,589.80
(84.66%)
synth_nested_borrow📈 view plot
🚷 view threshold
79,641.00
(+37.60%)
110,109.44
(72.33%)
test_batched_body📈 view plot
🚷 view threshold
1,935.50
(+0.81%)
2,040.91
(94.84%)
test_batched_body #2📈 view plot
🚷 view threshold
1,550,600.00
(-0.49%)
1,684,441.26
(92.05%)
test_data_loader📈 view plot
🚷 view threshold
393,080.00
(-5.07%)
443,480.26
(88.64%)
test_handle_request📈 view plot
🚷 view threshold
132,580.00
(-3.44%)
148,440.78
(89.32%)
test_handle_request_jit📈 view plot
🚷 view threshold
101,520.00
(-9.09%)
148,908.62
(68.18%)
test_http_execute_method📈 view plot
🚷 view threshold
14,170.00
(-1.28%)
14,883.41
(95.21%)
with_mustache_expressions📈 view plot
🚷 view threshold
1,125.90
(+1.41%)
1,179.71
(95.44%)
with_mustache_literal📈 view plot
🚷 view threshold
751.53
(+5.87%)
761.74
(98.66%)
🐰 View full continuous benchmarking report in Bencher

@tusharmath tusharmath changed the title chore: add dedupe capability on all IO operations feat: add dedupe capability on all IO operations Oct 1, 2024
@tusharmath tusharmath added type: feature Brand new functionality, features, pages, workflows, endpoints, etc. type: fix Iterations on existing features or infrastructure. and removed type: chore Routine tasks like conversions, reorganization, and maintenance work. type: feature Brand new functionality, features, pages, workflows, endpoints, etc. labels Oct 1, 2024
@tusharmath tusharmath changed the title feat: add dedupe capability on all IO operations fix: add dedupe capability on all IO operations Oct 1, 2024
src/core/jit/model.rs Outdated Show resolved Hide resolved
src/core/jit/model.rs Outdated Show resolved Hide resolved
@ssddOnTop ssddOnTop marked this pull request as draft October 1, 2024 04:43
@ssddOnTop ssddOnTop marked this pull request as ready for review October 1, 2024 06:01
@ssddOnTop ssddOnTop requested a review from tusharmath October 1, 2024 06:06
@tusharmath tusharmath enabled auto-merge (squash) October 1, 2024 06:34
@tusharmath tusharmath merged commit 8de419f into main Oct 1, 2024
31 checks passed
@tusharmath tusharmath deleted the dedupe-to-io-ops branch October 1, 2024 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci: benchmark Runs benchmarks type: fix Iterations on existing features or infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add dedupe capability on all IO operations
2 participants