Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): enable feature flag for hyper deprecated api #2940

Closed
wants to merge 1 commit into from

Conversation

amitksingh1490
Copy link
Collaborator

Summary:
Briefly describe the changes made in this PR.

Issue Reference(s):
Fixes #... (Replace "..." with the issue number)

Build & Testing:

  • I ran cargo test successfully.
  • I have run ./lint.sh --mode=fix to fix all linting issues raised by ./lint.sh --mode=check.

Checklist:

  • I have added relevant unit & integration tests.
  • I have updated the documentation accordingly.
  • I have performed a self-review of my code.
  • PR follows the naming convention of <type>(<optional scope>): <title>

@github-actions github-actions bot added type: feature Brand new functionality, features, pages, workflows, endpoints, etc. type: fix Iterations on existing features or infrastructure. labels Sep 29, 2024
@amitksingh1490 amitksingh1490 added ci: benchmark Runs benchmarks and removed type: feature Brand new functionality, features, pages, workflows, endpoints, etc. labels Sep 29, 2024
Copy link

codecov bot commented Sep 29, 2024

Codecov Report

Attention: Patch coverage is 84.21053% with 3 lines in your changes missing coverage. Please review.

Project coverage is 87.36%. Comparing base (1dbf9eb) to head (bf054d7).
Report is 94 commits behind head on main.

Files with missing lines Patch % Lines
src/core/rest/partial_request.rs 0.00% 1 Missing ⚠️
tailcall-cloudflare/src/http.rs 0.00% 1 Missing ⚠️
tailcall-wasm/src/lib.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2940   +/-   ##
=======================================
  Coverage   87.36%   87.36%           
=======================================
  Files         263      263           
  Lines       26252    26261    +9     
=======================================
+ Hits        22934    22943    +9     
  Misses       3318     3318           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Sep 29, 2024

🐰 Bencher Report

Branch2940/merge
Testbedbenchmarking-runner
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
nanoseconds (ns)
(Result Δ%)
Upper Boundary
nanoseconds (ns)
(Limit %)
from_json_bench📈 view plot
🚷 view threshold
6,246,300.00
(+0.68%)
6,359,711.69
(98.22%)
group_by📈 view plot
🚷 view threshold
489.34
(-0.13%)
512.56
(95.47%)
input/args.missing📈 view plot
🚷 view threshold
25.25
(-1.64%)
27.89
(90.52%)
input/args.nested.existing📈 view plot
🚷 view threshold
46.56
(+2.26%)
48.51
(95.98%)
input/args.nested.missing📈 view plot
🚷 view threshold
39.00
(+0.91%)
40.89
(95.37%)
input/args.root📈 view plot
🚷 view threshold
41.26
(-0.38%)
45.20
(91.29%)
input/headers.existing📈 view plot
🚷 view threshold
30.61
(-3.27%)
34.16
(89.61%)
input/headers.missing📈 view plot
🚷 view threshold
29.41
(-4.39%)
33.56
(87.61%)
input/value.missing📈 view plot
🚷 view threshold
23.27
(-0.67%)
24.63
(94.45%)
input/value.nested.existing📈 view plot
🚷 view threshold
42.52
(-1.41%)
45.92
(92.61%)
input/value.nested.missing📈 view plot
🚷 view threshold
37.72
(+3.46%)
38.37
(98.30%)
input/value.root📈 view plot
🚷 view threshold
38.80
(-0.22%)
42.15
(92.05%)
input/vars.existing📈 view plot
🚷 view threshold
8.44
(+2.34%)
9.52
(88.66%)
input/vars.missing📈 view plot
🚷 view threshold
12.31
(+29.88%)
12.68
(97.09%)
synth_nested📈 view plot
🚷 view threshold
135,010.00
(+23.32%)
158,308.26
(85.28%)
synth_nested_borrow📈 view plot
🚷 view threshold
83,694.00
(+47.50%)
109,249.34
(76.61%)
test_batched_body📈 view plot
🚷 view threshold
1,866.00
(-2.95%)
2,046.94
(91.16%)
test_batched_body #2📈 view plot
🚷 view threshold
1,594,500.00
(+2.18%)
1,687,412.95
(94.49%)
test_data_loader📈 view plot
🚷 view threshold
404,700.00
(-2.37%)
443,456.19
(91.26%)
test_handle_request📈 view plot
🚷 view threshold
135,310.00
(-1.61%)
148,659.03
(91.02%)
test_handle_request_jit📈 view plot
🚷 view threshold
97,963.00
(-12.18%)
148,993.02
(65.75%)
test_http_execute_method📈 view plot
🚷 view threshold
14,299.00
(-0.36%)
14,881.43
(96.09%)
with_mustache_expressions📈 view plot
🚷 view threshold
1,086.10
(-2.18%)
1,179.81
(92.06%)
with_mustache_literal📈 view plot
🚷 view threshold
714.53
(+0.64%)
761.62
(93.82%)
🐰 View full continuous benchmarking report in Bencher

@amitksingh1490 amitksingh1490 force-pushed the enable-deprecation-hyper branch from af024b3 to bf054d7 Compare September 29, 2024 12:31
@github-actions github-actions bot added the type: feature Brand new functionality, features, pages, workflows, endpoints, etc. label Sep 29, 2024
@amitksingh1490 amitksingh1490 removed type: feature Brand new functionality, features, pages, workflows, endpoints, etc. ci: benchmark Runs benchmarks labels Sep 29, 2024
Copy link

github-actions bot commented Oct 4, 2024

Action required: PR inactive for 5 days.
Status update or closure in 10 days.

@github-actions github-actions bot added state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. and removed state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. labels Oct 4, 2024
Copy link

github-actions bot commented Oct 9, 2024

Action required: PR inactive for 5 days.
Status update or closure in 10 days.

@github-actions github-actions bot added state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. and removed state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. labels Oct 9, 2024
Copy link

Action required: PR inactive for 5 days.
Status update or closure in 10 days.

@github-actions github-actions bot added state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. and removed state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. labels Oct 14, 2024
Copy link

Action required: PR inactive for 5 days.
Status update or closure in 10 days.

@github-actions github-actions bot added the state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. label Oct 19, 2024
Copy link

PR closed after 10 days of inactivity.

@github-actions github-actions bot closed this Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. type: fix Iterations on existing features or infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant