Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): use http crate for consistency #2939

Merged
merged 1 commit into from
Sep 29, 2024
Merged

Conversation

amitksingh1490
Copy link
Collaborator

@amitksingh1490 amitksingh1490 commented Sep 29, 2024

used http crate for Request and Response

@github-actions github-actions bot added ci: benchmark Runs benchmarks type: chore Routine tasks like conversions, reorganization, and maintenance work. labels Sep 29, 2024
@amitksingh1490 amitksingh1490 removed the ci: benchmark Runs benchmarks label Sep 29, 2024
@github-actions github-actions bot added the ci: benchmark Runs benchmarks label Sep 29, 2024
@amitksingh1490 amitksingh1490 removed the ci: benchmark Runs benchmarks label Sep 29, 2024
Copy link

codecov bot commented Sep 29, 2024

Codecov Report

Attention: Patch coverage is 47.27273% with 29 lines in your changes missing coverage. Please review.

Project coverage is 87.36%. Comparing base (0221431) to head (27918cb).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
tailcall-cloudflare/src/http.rs 0.00% 13 Missing ⚠️
tailcall-aws-lambda/src/http.rs 52.94% 8 Missing ⚠️
src/core/http/method.rs 60.00% 4 Missing ⚠️
tailcall-wasm/src/lib.rs 0.00% 2 Missing ⚠️
src/core/valid/error.rs 0.00% 1 Missing ⚠️
src/core/worker/error.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2939   +/-   ##
=======================================
  Coverage   87.35%   87.36%           
=======================================
  Files         263      263           
  Lines       26254    26252    -2     
=======================================
  Hits        22934    22934           
+ Misses       3320     3318    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

🐰 Bencher Report

Branch2939/merge
Testbedbenchmarking-runner
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
nanoseconds (ns)
(Result Δ%)
Upper Boundary
nanoseconds (ns)
(Limit %)
from_json_bench📈 view plot
🚷 view threshold
6,289,600.00
(+1.38%)
6,359,830.39
(98.90%)
group_by📈 view plot
🚷 view threshold
491.56
(+0.34%)
512.27
(95.96%)
input/args.missing📈 view plot
🚷 view threshold
25.61
(-0.24%)
27.90
(91.81%)
input/args.nested.existing📈 view plot
🚷 view threshold
45.32
(-0.45%)
48.50
(93.44%)
input/args.nested.missing📈 view plot
🚷 view threshold
38.06
(-1.51%)
40.91
(93.05%)
input/args.root📈 view plot
🚷 view threshold
42.01
(+1.47%)
45.19
(92.98%)
input/headers.existing📈 view plot
🚷 view threshold
32.86
(+3.77%)
34.17
(96.15%)
input/headers.missing📈 view plot
🚷 view threshold
31.71
(+3.04%)
33.58
(94.43%)
input/value.missing📈 view plot
🚷 view threshold
23.36
(-0.25%)
24.63
(94.85%)
input/value.nested.existing📈 view plot
🚷 view threshold
43.75
(+1.42%)
45.92
(95.27%)
input/value.nested.missing📈 view plot
🚷 view threshold
36.62
(+0.46%)
38.37
(95.45%)
input/value.root📈 view plot
🚷 view threshold
41.50
(+6.69%)
42.18
(98.37%)
input/vars.existing📈 view plot
🚷 view threshold
8.55
(+3.68%)
9.51
(89.89%)
input/vars.missing📈 view plot
🚷 view threshold
12.54
(+32.78%)
12.59
(99.59%)
synth_nested📈 view plot
🚷 view threshold
137,190.00
(+25.67%)
157,832.21
(86.92%)
synth_nested_borrow📈 view plot
🚷 view threshold
82,508.00
(+45.90%)
109,074.86
(75.64%)
test_batched_body📈 view plot
🚷 view threshold
1,906.80
(-0.87%)
2,048.17
(93.10%)
test_batched_body #2📈 view plot
🚷 view threshold
1,529,100.00
(-2.04%)
1,687,755.82
(90.60%)
test_data_loader📈 view plot
🚷 view threshold
400,050.00
(-3.52%)
443,604.77
(90.18%)
test_handle_request📈 view plot
🚷 view threshold
134,620.00
(-2.17%)
148,834.49
(90.45%)
test_handle_request_jit📈 view plot
🚷 view threshold
98,896.00
(-11.30%)
149,056.54
(66.35%)
test_http_execute_method📈 view plot
🚷 view threshold
14,410.00
(+0.40%)
14,883.47
(96.82%)
with_mustache_expressions📈 view plot
🚷 view threshold
1,123.80
(+1.20%)
1,179.96
(95.24%)
with_mustache_literal📈 view plot
🚷 view threshold
698.84
(-1.59%)
761.73
(91.74%)
🐰 View full continuous benchmarking report in Bencher

@amitksingh1490 amitksingh1490 marked this pull request as ready for review September 29, 2024 10:30
@amitksingh1490 amitksingh1490 merged commit 677219f into main Sep 29, 2024
35 of 37 checks passed
@amitksingh1490 amitksingh1490 deleted the use-http-crate branch September 29, 2024 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: chore Routine tasks like conversions, reorganization, and maintenance work.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant