Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add enableFederation flag to server #2919

Merged
merged 4 commits into from
Oct 1, 2024
Merged

Conversation

meskill
Copy link
Contributor

@meskill meskill commented Sep 26, 2024

Summary:
Briefly describe the changes made in this PR.

Issue Reference(s):
Fixes #... (Replace "..." with the issue number)

Build & Testing:

  • I ran cargo test successfully.
  • I have run ./lint.sh --mode=fix to fix all linting issues raised by ./lint.sh --mode=check.

Checklist:

  • I have added relevant unit & integration tests.
  • I have updated the documentation accordingly.
  • I have performed a self-review of my code.
  • PR follows the naming convention of <type>(<optional scope>): <title>

@github-actions github-actions bot added the type: feature Brand new functionality, features, pages, workflows, endpoints, etc. label Sep 26, 2024
Copy link

codecov bot commented Sep 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.44%. Comparing base (aab7e07) to head (a4f23ef).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2919   +/-   ##
=======================================
  Coverage   87.43%   87.44%           
=======================================
  Files         263      263           
  Lines       26422    26428    +6     
=======================================
+ Hits        23103    23109    +6     
  Misses       3319     3319           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

# Conflicts:
#	generated/.tailcallrc.graphql
#	generated/.tailcallrc.schema.json
#	tests/core/snapshots/apollo-federation-entities-batch.md_1.snap
#	tests/core/snapshots/apollo-federation-entities.md_1.snap
@tusharmath
Copy link
Contributor

tusharmath commented Sep 30, 2024

  • Create a PR for docs.
  • Resolve conflicts.

@tusharmath tusharmath marked this pull request as draft September 30, 2024 09:46
@meskill
Copy link
Contributor Author

meskill commented Sep 30, 2024

  • Create a PR for docs.
  • Resolve conflicts.

tailcallhq/tailcallhq.github.io#524

@meskill meskill marked this pull request as ready for review September 30, 2024 12:45
@tusharmath tusharmath changed the title feat: add @server flag to enable federation feat: add enableFederation flag to server Oct 1, 2024
@tusharmath tusharmath enabled auto-merge (squash) October 1, 2024 03:50
@tusharmath tusharmath merged commit cec5896 into main Oct 1, 2024
37 checks passed
@tusharmath tusharmath deleted the feat/federation-flag branch October 1, 2024 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature Brand new functionality, features, pages, workflows, endpoints, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants