Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added type rename support for enum, union and interface. #2793

Merged
merged 8 commits into from
Sep 21, 2024

Conversation

laststylebender14
Copy link
Contributor

@laststylebender14 laststylebender14 commented Sep 5, 2024

Summary:
previously rename types transformer supported only renaming in normal types, now extended the support to enum, union and interface types.

Issue Reference(s):
Fixes #... (Replace "..." with the issue number)

Build & Testing:

  • I ran cargo test successfully.
  • I have run ./lint.sh --mode=fix to fix all linting issues raised by ./lint.sh --mode=check.

Checklist:

  • I have added relevant unit & integration tests.
  • I have updated the documentation accordingly.
  • I have performed a self-review of my code.
  • PR follows the naming convention of <type>(<optional scope>): <title>

@github-actions github-actions bot added the type: fix Iterations on existing features or infrastructure. label Sep 5, 2024
@laststylebender14 laststylebender14 marked this pull request as draft September 5, 2024 17:54
Copy link

codecov bot commented Sep 5, 2024

Codecov Report

Attention: Patch coverage is 97.70115% with 2 lines in your changes missing coverage. Please review.

Project coverage is 87.18%. Comparing base (86b26b8) to head (b1b5de1).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/core/config/transformer/rename_types.rs 97.64% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2793      +/-   ##
==========================================
+ Coverage   87.15%   87.18%   +0.02%     
==========================================
  Files         256      256              
  Lines       25402    25462      +60     
==========================================
+ Hits        22140    22199      +59     
- Misses       3262     3263       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@laststylebender14 laststylebender14 marked this pull request as ready for review September 5, 2024 18:24
Copy link

Action required: PR inactive for 5 days.
Status update or closure in 10 days.

@github-actions github-actions bot added state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. and removed state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. labels Sep 10, 2024
Copy link
Contributor

@karatakis karatakis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found some slips, but overall its a great work.

src/core/config/transformer/rename_types.rs Outdated Show resolved Hide resolved
src/core/config/transformer/rename_types.rs Outdated Show resolved Hide resolved
src/core/config/transformer/rename_types.rs Outdated Show resolved Hide resolved
Copy link

Action required: PR inactive for 5 days.
Status update or closure in 10 days.

@github-actions github-actions bot added the state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. label Sep 21, 2024
@tusharmath tusharmath enabled auto-merge (squash) September 21, 2024 11:08
@tusharmath tusharmath merged commit b6ce0cf into main Sep 21, 2024
30 checks passed
@tusharmath tusharmath deleted the fix/rename-types-in-args-unions-interfaces-enums branch September 21, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. type: fix Iterations on existing features or infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants