chore: drop cloning of OperationPlan #2792
Closed
+69
−58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
type: chore
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2792 +/- ##
=======================================
Coverage 87.84% 87.84%
=======================================
Files 263 263
Lines 26252 26253 +1
=======================================
+ Hits 23061 23062 +1
Misses 3191 3191 ☔ View full report in Codecov by Sentry. |
|
| Report | Wed, September 4, 2024 at 20:47:49 UTC |
| Project | tailcall |
| Branch | 2792/merge |
| Testbed | benchmarking-runner |
🚨 2 ALERTS: Threshold Boundary Limits exceeded!
| Benchmark | Measure (units) | View | Value | Lower Boundary | Upper Boundary |
|---|---|---|---|---|---|
| from_json_bench | Latency (nanoseconds (ns)) | 🚨 (view plot | view alert) | 6,356,800.00 (+3.13%) | 6,289,532.22 (101.07%) | |
| input/vars.missing | Latency (nanoseconds (ns)) | 🚨 (view plot | view alert) | 10.97 (+27.27%) | 10.82 (101.41%) |
Click to view all benchmark results
| Benchmark | Latency | Latency Results nanoseconds (ns) | (Δ%) | Latency Upper Boundary nanoseconds (ns) | (%) |
|---|---|---|---|
| from_json_bench | 🚨 (view plot | view alert) | 6,356,800.00 (+3.13%) | 6,289,532.22 (101.07%) |
| group_by | ✅ (view plot) | 480.45 (-1.89%) | 512.74 (93.70%) |
| input/args.missing | ✅ (view plot) | 25.21 (-1.49%) | 27.81 (90.68%) |
| input/args.nested.existing | ✅ (view plot) | 44.76 (-3.94%) | 53.21 (84.12%) |
| input/args.nested.missing | ✅ (view plot) | 38.54 (-0.41%) | 40.82 (94.42%) |
| input/args.root | ✅ (view plot) | 39.99 (-6.12%) | 49.93 (80.11%) |
| input/headers.existing | ✅ (view plot) | 32.64 (+3.33%) | 34.13 (95.64%) |
| input/headers.missing | ✅ (view plot) | 31.61 (+3.10%) | 33.49 (94.39%) |
| input/value.missing | ✅ (view plot) | 23.27 (-0.47%) | 24.67 (94.31%) |
| input/value.nested.existing | ✅ (view plot) | 45.53 (+5.98%) | 45.88 (99.24%) |
| input/value.nested.missing | ✅ (view plot) | 35.68 (-3.16%) | 39.67 (89.94%) |
| input/value.root | ✅ (view plot) | 36.77 (-4.40%) | 41.39 (88.83%) |
| input/vars.existing | ✅ (view plot) | 7.81 (-5.31%) | 9.45 (82.65%) |
| input/vars.missing | 🚨 (view plot | view alert) | 10.97 (+27.27%) | 10.82 (101.41%) |
| synth_nested | ✅ (view plot) | 125,640.00 (+13.62%) | 189,877.98 (66.17%) |
| synth_nested_borrow | ✅ (view plot) | 82,696.00 (+90.78%) | 87,484.18 (94.53%) |
| test_batched_body | ✅ (view plot) | 1,860.30 (-5.17%) | 2,098.72 (88.64%) |
| test_batched_body #2 | ✅ (view plot) | 1,502,000.00 (-6.37%) | 1,754,155.51 (85.63%) |
| test_data_loader | ✅ (view plot) | 398,390.00 (-1.49%) | 462,507.19 (86.14%) |
| test_handle_request | ✅ (view plot) | 129,660.00 (-8.21%) | 149,068.89 (86.98%) |
| test_handle_request_jit | ✅ (view plot) | 136,230.00 (+27.04%) | 142,826.01 (95.38%) |
| test_http_execute_method | ✅ (view plot) | 14,258.00 (-0.71%) | 14,911.72 (95.62%) |
| with_mustache_expressions | ✅ (view plot) | 1,105.70 (-0.43%) | 1,176.82 (93.96%) |
| with_mustache_literal | ✅ (view plot) | 670.26 (-6.17%) | 767.20 (87.36%) |
Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help
|
Action required: PR inactive for 5 days. |
github-actions
bot
added
state: inactive
|
Action required: PR inactive for 5 days. |
github-actions
bot
added
the
state: inactive
github-actions
bot
removed
the
state: inactive
|
@ssddOnTop I am closing this PR for now. There is no clarity on performance impact this change brings in. Lets get back to it sometime later when we can methodologically test & optimize |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.