Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(2781): support gRPC reflection custom headers #2790

Merged
merged 9 commits into from
Sep 25, 2024
Merged

feat(2781): support gRPC reflection custom headers #2790

merged 9 commits into from
Sep 25, 2024

Conversation

beelchester
Copy link
Contributor

fixes #2781
/claim #2781

@algora-pbc algora-pbc bot mentioned this pull request Sep 4, 2024
Closed
@github-actions github-actions bot added the type: feature Brand new functionality, features, pages, workflows, endpoints, etc. label Sep 4, 2024
@beelchester beelchester force-pushed the feat/link-custom-headers branch from 53d8ee7 to dc16ec7 Compare September 8, 2024 07:27
@beelchester beelchester marked this pull request as ready for review September 8, 2024 07:28
@beelchester beelchester changed the title feat(2781): support gRPC reflection custom metadata feat(2781): support gRPC reflection custom headers Sep 8, 2024
@codecov Codecov
Copy link

codecov bot commented Sep 8, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 93.25843% with 6 lines in your changes missing coverage. Please review.

Project coverage is 87.84%. Comparing base (c8b1f2c) to head (3b7ba09).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
tailcall-upstream-grpc/src/main.rs 0.00% 6 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2790      +/-   ##
==========================================
+ Coverage   87.82%   87.84%   +0.01%     
==========================================
  Files         263      263              
  Lines       26179    26252      +73     
==========================================
+ Hits        22993    23061      +68     
- Misses       3186     3191       +5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

karatakis
karatakis reviewed Sep 11, 2024
View reviewed changes
Copy link
Contributor

@karatakis karatakis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found some stuff, but nothing scary

src/core/proto_reader/fetch.rs Outdated Show resolved Hide resolved
src/core/proto_reader/fetch.rs Outdated Show resolved Hide resolved
src/core/proto_reader/fetch.rs Outdated Show resolved Hide resolved
src/core/proto_reader/fetch.rs Outdated Show resolved Hide resolved
src/core/proto_reader/reader.rs Outdated Show resolved Hide resolved
@beelchester beelchester force-pushed the feat/link-custom-headers branch from b46d059 to 13d4f7f Compare September 12, 2024 03:43
karatakis
karatakis approved these changes Sep 16, 2024
View reviewed changes
Copy link
Contributor

@karatakis karatakis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok

@tusharmath
Copy link
Contributor

@beelchester Can you please update the documentation for this change.

@tusharmath tusharmath enabled auto-merge (squash) September 25, 2024 09:03
@tusharmath tusharmath merged commit 8e3e965 into tailcallhq:main Sep 25, 2024
31 checks passed
@beelchester beelchester mentioned this pull request Sep 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karatakis karatakis karatakis approved these changes

Assignees
No one assigned
Labels
🙋 Bounty claim type: feature Brand new functionality, features, pages, workflows, endpoints, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: Add Support for Custom Headers in gRPC Reflection Requests
3 participants
@beelchester @tusharmath @karatakis