Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use a consistent prefix for auto-generated names #2783

Merged
merged 29 commits into from
Sep 21, 2024

Conversation

laststylebender14
Copy link
Contributor

@laststylebender14 laststylebender14 commented Sep 2, 2024

Summary:
Previously we were generating types names with LLM for types that already have good name (manually inferred.), this PR ensures only types with GEN__ prefix are processed with LLM.

Issue Reference(s):
Fixes #... (Replace "..." with the issue number)

Build & Testing:

  • I ran cargo test successfully.
  • I have run ./lint.sh --mode=fix to fix all linting issues raised by ./lint.sh --mode=check.

Checklist:

  • I have added relevant unit & integration tests.
  • I have updated the documentation accordingly.
  • I have performed a self-review of my code.
  • PR follows the naming convention of <type>(<optional scope>): <title>

- update the prompt to hold used type names
@github-actions github-actions bot added the type: feature Brand new functionality, features, pages, workflows, endpoints, etc. label Sep 2, 2024
@laststylebender14 laststylebender14 marked this pull request as draft September 2, 2024 18:42
@laststylebender14 laststylebender14 marked this pull request as ready for review September 2, 2024 19:20
Copy link

codecov bot commented Sep 2, 2024

Codecov Report

Attention: Patch coverage is 77.77778% with 16 lines in your changes missing coverage. Please review.

Project coverage is 87.17%. Comparing base (2cf0f58) to head (4b16d10).

Files with missing lines Patch % Lines
src/cli/llm/infer_type_name.rs 64.44% 16 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2783      +/-   ##
==========================================
- Coverage   87.18%   87.17%   -0.02%     
==========================================
  Files         256      256              
  Lines       25516    25558      +42     
==========================================
+ Hits        22247    22280      +33     
- Misses       3269     3278       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…ing in correct format and remove extra iteration over it.
@laststylebender14 laststylebender14 marked this pull request as draft September 3, 2024 10:28
@laststylebender14 laststylebender14 marked this pull request as ready for review September 4, 2024 16:01
@laststylebender14 laststylebender14 marked this pull request as draft September 4, 2024 18:07
Copy link

Action required: PR inactive for 5 days.
Status update or closure in 10 days.

@github-actions github-actions bot added state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. and removed state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. labels Sep 14, 2024
@laststylebender14 laststylebender14 marked this pull request as ready for review September 16, 2024 06:50
@tusharmath tusharmath changed the title feat: process only auto generated type names refactor: use a consistent prefix for auto-generated names. Sep 16, 2024
@tusharmath tusharmath changed the title refactor: use a consistent prefix for auto-generated names. refactor: use a consistent prefix for auto-generated names Sep 16, 2024
@tusharmath tusharmath marked this pull request as draft September 16, 2024 23:08
@github-actions github-actions bot added type: chore Routine tasks like conversions, reorganization, and maintenance work. type: fix Iterations on existing features or infrastructure. labels Sep 17, 2024
@laststylebender14 laststylebender14 marked this pull request as ready for review September 17, 2024 07:37
# Conflicts:
#	src/core/generator/snapshots/tailcall__core__generator__generator__test__should_generate_combined_config.snap
#	tests/cli/snapshots/cli_spec__test__generator_spec__tests__cli__fixtures__generator__gen_json_proto_mix_config.md.snap
@tusharmath tusharmath enabled auto-merge (squash) September 21, 2024 12:33
@tusharmath tusharmath disabled auto-merge September 21, 2024 13:50
@tusharmath tusharmath merged commit 7144fd3 into main Sep 21, 2024
10 checks passed
@tusharmath tusharmath deleted the feat/process-only-generated-type-names branch September 21, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: chore Routine tasks like conversions, reorganization, and maintenance work. type: feature Brand new functionality, features, pages, workflows, endpoints, etc. type: fix Iterations on existing features or infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants