-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: use a consistent prefix for auto-generated names #2783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- update the prompt to hold used type names
github-actions
bot
added
the
type: feature
Brand new functionality, features, pages, workflows, endpoints, etc.
label
Sep 2, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2783 +/- ##
==========================================
- Coverage 87.18% 87.17% -0.02%
==========================================
Files 256 256
Lines 25516 25558 +42
==========================================
+ Hits 22247 22280 +33
- Misses 3269 3278 +9 ☔ View full report in Codecov by Sentry. |
…ing in correct format and remove extra iteration over it.
Action required: PR inactive for 5 days. |
github-actions
bot
added
state: inactive
No current action needed/possible; issue fixed, out of scope, or superseded.
and removed
state: inactive
No current action needed/possible; issue fixed, out of scope, or superseded.
labels
Sep 14, 2024
tusharmath
reviewed
Sep 16, 2024
tusharmath
reviewed
Sep 16, 2024
tusharmath
reviewed
Sep 16, 2024
tusharmath
reviewed
Sep 16, 2024
tusharmath
reviewed
Sep 16, 2024
tusharmath
reviewed
Sep 16, 2024
tusharmath
changed the title
feat: process only auto generated type names
refactor: use a consistent prefix for auto-generated names.
Sep 16, 2024
tusharmath
changed the title
refactor: use a consistent prefix for auto-generated names.
refactor: use a consistent prefix for auto-generated names
Sep 16, 2024
github-actions
bot
added
type: chore
Routine tasks like conversions, reorganization, and maintenance work.
type: fix
Iterations on existing features or infrastructure.
labels
Sep 17, 2024
# Conflicts: # src/core/generator/snapshots/tailcall__core__generator__generator__test__should_generate_combined_config.snap # tests/cli/snapshots/cli_spec__test__generator_spec__tests__cli__fixtures__generator__gen_json_proto_mix_config.md.snap
tusharmath
approved these changes
Sep 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
type: chore
Routine tasks like conversions, reorganization, and maintenance work.
type: feature
Brand new functionality, features, pages, workflows, endpoints, etc.
type: fix
Iterations on existing features or infrastructure.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Previously we were generating types names with LLM for types that already have good name (manually inferred.), this PR ensures only types with
GEN__
prefix are processed with LLM.Issue Reference(s):
Fixes #... (Replace "..." with the issue number)
Build & Testing:
cargo test
successfully../lint.sh --mode=fix
to fix all linting issues raised by./lint.sh --mode=check
.Checklist:
<type>(<optional scope>): <title>