Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: simplify json_like trait #2780

Merged
merged 1 commit into from
Sep 3, 2024
Merged

Conversation

meskill
Copy link
Contributor

@meskill meskill commented Sep 1, 2024

Summary:
Simplify JsonLike associated type constraints according to TODO in the code. This is doable after serde_json_borrow update PSeitz/serde_json_borrow#19

Build & Testing:

  • I ran cargo test successfully.
  • I have run ./lint.sh --mode=fix to fix all linting issues raised by ./lint.sh --mode=check.

Checklist:

  • I have added relevant unit & integration tests.
  • I have updated the documentation accordingly.
  • I have performed a self-review of my code.
  • PR follows the naming convention of <type>(<optional scope>): <title>

@github-actions github-actions bot added the type: chore Routine tasks like conversions, reorganization, and maintenance work. label Sep 1, 2024
Copy link

codecov bot commented Sep 1, 2024

Codecov Report

Attention: Patch coverage is 57.89474% with 8 lines in your changes missing coverage. Please review.

Project coverage is 87.13%. Comparing base (d473af2) to head (80b9490).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/core/json/serde.rs 0.00% 5 Missing ⚠️
src/core/json/borrow.rs 60.00% 2 Missing ⚠️
src/core/json/graphql.rs 80.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2780   +/-   ##
=======================================
  Coverage   87.13%   87.13%           
=======================================
  Files         254      254           
  Lines       25144    25144           
=======================================
  Hits        21909    21909           
  Misses       3235     3235           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tusharmath tusharmath merged commit 1eb224b into main Sep 3, 2024
37 of 38 checks passed
@tusharmath tusharmath deleted the refactor/json-like-simple branch September 3, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: chore Routine tasks like conversions, reorganization, and maintenance work.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants