Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(jit): handling nested lists #2779

Merged
merged 32 commits into from
Sep 17, 2024
Merged

fix(jit): handling nested lists #2779

merged 32 commits into from
Sep 17, 2024

Conversation

meskill
Copy link
Contributor

@meskill meskill commented Sep 1, 2024

Summary:

Following change to #2747 related to jit engine. Now jit is also able to properly resolve nested values for data of type list of any nesting.

To implement this I've changed an approach how to store resolved values in store and resolvers are executed

Build & Testing:

  • I ran cargo test successfully.
  • I have run ./lint.sh --mode=fix to fix all linting issues raised by ./lint.sh --mode=check.

Checklist:

  • I have added relevant unit & integration tests.
  • I have updated the documentation accordingly.
  • I have performed a self-review of my code.
  • PR follows the naming convention of <type>(<optional scope>): <title>

@github-actions github-actions bot added the type: fix Iterations on existing features or infrastructure. label Sep 1, 2024
Copy link

codecov bot commented Sep 1, 2024

Codecov Report

Attention: Patch coverage is 98.97959% with 2 lines in your changes missing coverage. Please review.

Project coverage is 87.24%. Comparing base (9b7a7ce) to head (eff91fa).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/core/jit/exec.rs 96.15% 1 Missing ⚠️
src/core/jit/synth/synth.rs 95.45% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2779      +/-   ##
==========================================
+ Coverage   87.14%   87.24%   +0.10%     
==========================================
  Files         254      254              
  Lines       25148    25190      +42     
==========================================
+ Hits        21914    21977      +63     
+ Misses       3234     3213      -21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Sep 9, 2024

Action required: PR inactive for 5 days.
Status update or closure in 10 days.

@github-actions github-actions bot added state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. and removed state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. labels Sep 9, 2024
@meskill meskill marked this pull request as draft September 13, 2024 09:53
@meskill meskill marked this pull request as ready for review September 16, 2024 14:53
@tusharmath tusharmath enabled auto-merge (squash) September 16, 2024 23:15
@tusharmath tusharmath merged commit 976649c into main Sep 17, 2024
31 checks passed
@tusharmath tusharmath deleted the fix/jit-nested-list branch September 17, 2024 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: fix Iterations on existing features or infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants