Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(jit): error handling for lists in JIT #2771

Merged
merged 5 commits into from
Aug 30, 2024

Conversation

laststylebender14
Copy link
Contributor

Summary:
Briefly describe the changes made in this PR.

Issue Reference(s):
Fixes #... (Replace "..." with the issue number)

Build & Testing:

  • I ran cargo test successfully.
  • I have run ./lint.sh --mode=fix to fix all linting issues raised by ./lint.sh --mode=check.

Checklist:

  • I have added relevant unit & integration tests.
  • I have updated the documentation accordingly.
  • I have performed a self-review of my code.
  • PR follows the naming convention of <type>(<optional scope>): <title>

@github-actions github-actions bot added the type: fix Iterations on existing features or infrastructure. label Aug 30, 2024
@tusharmath tusharmath added the ci: test-jit Run all integration tests for the JIT optimized engine label Aug 30, 2024
@laststylebender14 laststylebender14 marked this pull request as draft August 30, 2024 09:43
Copy link

codecov bot commented Aug 30, 2024

Codecov Report

Attention: Patch coverage is 96.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 86.95%. Comparing base (bbd6d4d) to head (06f7fc1).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/core/jit/synth/synth.rs 96.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2771      +/-   ##
==========================================
+ Coverage   86.76%   86.95%   +0.19%     
==========================================
  Files         254      254              
  Lines       25147    25144       -3     
==========================================
+ Hits        21818    21864      +46     
+ Misses       3329     3280      -49     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@laststylebender14 laststylebender14 marked this pull request as ready for review August 30, 2024 10:09
@tusharmath tusharmath merged commit 0634073 into main Aug 30, 2024
36 checks passed
@tusharmath tusharmath deleted the fix/jit-error-handling-for-lists branch August 30, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci: test-jit Run all integration tests for the JIT optimized engine type: fix Iterations on existing features or infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants