Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(2695): derive macro for config::Resolver #2721

Merged
merged 7 commits into from
Aug 19, 2024
Merged

refactor(2695): derive macro for config::Resolver #2721

merged 7 commits into from
Aug 19, 2024

Conversation

mehulmathur16
Copy link
Contributor

/claim #2695

@algora-pbc algora-pbc bot mentioned this pull request Aug 16, 2024
Closed
@github-actions github-actions bot added the type: chore Routine tasks like conversions, reorganization, and maintenance work. label Aug 16, 2024
@mehulmathur16 mehulmathur16 changed the title refactor: derive macro for config::Resolver refactor(2695): derive macro for config::Resolver Aug 16, 2024
@mehulmathur16 mehulmathur16 requested a review from meskill August 16, 2024 19:47
@codecov Codecov
Copy link

codecov bot commented Aug 16, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.46%. Comparing base (edc81dc) to head (f640d34).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2721      +/-   ##
==========================================
- Coverage   86.47%   86.46%   -0.02%     
==========================================
  Files         255      255              
  Lines       25008    24963      -45     
==========================================
- Hits        21626    21584      -42     
+ Misses       3382     3379       -3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tusharmath tusharmath marked this pull request as draft August 17, 2024 13:32
@tusharmath tusharmath marked this pull request as ready for review August 17, 2024 14:08
@tusharmath
Copy link
Contributor

@meskill LGTM. Can you also check once.

meskill
meskill requested changes Aug 19, 2024
View reviewed changes
tailcall-macros/src/resolver.rs Outdated Show resolved Hide resolved
tailcall-macros/src/resolver.rs Outdated Show resolved Hide resolved
tailcall-macros/src/resolver.rs Outdated Show resolved Hide resolved
tailcall-macros/src/resolver.rs Outdated Show resolved Hide resolved
@meskill meskill merged commit 2e59303 into main Aug 19, 2024
36 checks passed
@meskill meskill deleted the refactor-resolver branch August 19, 2024 10:28
beelchester pushed a commit to beelchester/tailcall that referenced this pull request Aug 21, 2024
@mehulmathur16 @beelchester
refactor(2695): derive macro for config::Resolver (tailcallhq#2721)
b89764d
beelchester pushed a commit to beelchester/tailcall that referenced this pull request Aug 21, 2024
@mehulmathur16 @beelchester
refactor(2695): derive macro for config::Resolver (tailcallhq#2721)
2613470
beelchester pushed a commit to beelchester/tailcall that referenced this pull request Aug 21, 2024
@mehulmathur16 @beelchester
refactor(2695): derive macro for config::Resolver (tailcallhq#2721)
233fa50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tusharmath tusharmath tusharmath left review comments

@meskill meskill meskill approved these changes

Assignees
No one assigned
Labels
🙋 Bounty claim type: chore Routine tasks like conversions, reorganization, and maintenance work.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mehulmathur16 @tusharmath @meskill