Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(2688): --watch for changes #2707

Closed
wants to merge 29 commits into from
Closed

feat(2688): --watch for changes #2707

wants to merge 29 commits into from

Conversation

beelchester
Copy link
Contributor

@beelchester beelchester commented Aug 15, 2024 •
edited
Loading

fixes: #2688
/claim #2688

Example

tailcall_watch.mp4

@algora-pbc algora-pbc bot mentioned this pull request Aug 15, 2024
Closed
@github-actions github-actions bot added the type: feature Brand new functionality, features, pages, workflows, endpoints, etc. label Aug 15, 2024
@beelchester beelchester marked this pull request as draft August 15, 2024 10:02
@codecov Codecov
Copy link

codecov bot commented Aug 15, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0.66225% with 150 lines in your changes missing coverage. Please review.

Project coverage is 87.11%. Comparing base (b3261e4) to head (0007f39).
Report is 64 commits behind head on main.

Files with missing lines Patch % Lines
src/cli/tc/start.rs 0.00% 139 Missing ⚠️
src/cli/server/http_server.rs 0.00% 8 Missing ⚠️
src/cli/tc/run.rs 0.00% 2 Missing ⚠️
src/cli/command.rs 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2707      +/-   ##
==========================================
- Coverage   87.55%   87.11%   -0.44%     
==========================================
  Files         275      275              
  Lines       27256    27393     +137     
==========================================
  Hits        23863    23863              
- Misses       3393     3530     +137

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@beelchester beelchester force-pushed the feat/watch-path branch 2 times, most recently from 4db457c to 2c39fd7 Compare August 15, 2024 14:29
@beelchester
feat: watch changes in path
6932843 
Signed-off-by: Sahil Yeole <[email protected]>
@beelchester
revert comment
0abc74b 
Signed-off-by: Sahil Yeole <[email protected]>
@beelchester
remove outer task
9645c38 
Signed-off-by: Sahil Yeole <[email protected]>
@beelchester
use config_error flag and content event for notify
a532348 
Signed-off-by: Sahil Yeole <[email protected]>
@beelchester
refact: start_watch_server
63fe1c2 
Signed-off-by: Sahil Yeole <[email protected]>
@beelchester
optimize server in watch mode
15c40b9 
Signed-off-by: Sahil Yeole <[email protected]>
@beelchester
remove separate watch task
1879460 
Signed-off-by: Sahil Yeole <[email protected]>
@beelchester
watch for linked files also and add debounce delay
02f0b23 
Signed-off-by: Sahil Yeole <[email protected]>
@beelchester
fix: first server run sometimes fails
1233dea 
Signed-off-by: Sahil Yeole <[email protected]>
@beelchester
fix: add delay to let server stop
4b9dd5f 
Signed-off-by: Sahil Yeole <[email protected]>
@beelchester
update command description
75cd209 
Signed-off-by: Sahil Yeole <[email protected]>
@beelchester
increase init last_event_time
19f53f0 
Signed-off-by: Sahil Yeole <[email protected]>
@beelchester
fix: build
a27bbda 
Signed-off-by: Sahil Yeole <[email protected]>
@github-actions GitHub Actions
Copy link

Action required: PR inactive for 5 days.
Status update or closure in 10 days.

@github-actions github-actions bot added the state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. label Aug 22, 2024
@beelchester beelchester marked this pull request as ready for review August 23, 2024 06:25
@github-actions github-actions bot removed the state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. label Aug 23, 2024
@beelchester
fix: lint
cd40bec 
Signed-off-by: Sahil Yeole <[email protected]>
@beelchester beelchester marked this pull request as ready for review August 31, 2024 04:02
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 6, 2024

Action required: PR inactive for 5 days.
Status update or closure in 10 days.

@github-actions github-actions bot added the state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. label Sep 6, 2024
@github-actions github-actions bot removed the state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. label Sep 8, 2024
@github-actions GitHub Actions
Copy link

Action required: PR inactive for 5 days.
Status update or closure in 10 days.

@github-actions github-actions bot added the state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. label Sep 13, 2024
@github-actions github-actions bot removed the state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. label Sep 15, 2024
tusharmath
tusharmath reviewed Sep 16, 2024
View reviewed changes
src/cli/server/http_server.rs
@@ -12,6 +14,10 @@ use crate::core::blueprint::{Blueprint, Http};
use crate::core::config::ConfigModule;
use crate::core::Errata;

lazy_static! {
pub static ref RUNTIME: Arc<Mutex<Option<Runtime>>> = Arc::new(Mutex::new(None));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move the runtime into the server. Let's not create static runtimes this way.

@tusharmath
Copy link
Contributor

Moving to draft to reduce noise and improve CI efficiency. Once you are ready just mark it as "ready to review". Feel free to give a shoutout on the #contributors channel on Discord if you want immediate attention.

@tusharmath tusharmath marked this pull request as draft September 16, 2024 22:54
@github-actions GitHub Actions
Copy link

Action required: PR inactive for 5 days.
Status update or closure in 10 days.

@github-actions github-actions bot added the state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. label Sep 21, 2024
@github-actions github-actions bot removed the state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. label Sep 24, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 4, 2024

Action required: PR inactive for 5 days.
Status update or closure in 10 days.

@github-actions github-actions bot added the state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. label Oct 4, 2024
@github-actions github-actions bot removed the state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. label Oct 9, 2024
@github-actions GitHub Actions
Copy link

Action required: PR inactive for 5 days.
Status update or closure in 10 days.

@github-actions github-actions bot added state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. and removed state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. labels Oct 14, 2024
@github-actions GitHub Actions
Copy link

Action required: PR inactive for 5 days.
Status update or closure in 10 days.

@github-actions github-actions bot added the state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. label Oct 19, 2024
@github-actions GitHub Actions
Copy link

PR closed after 10 days of inactivity.

@github-actions github-actions bot closed this Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tusharmath tusharmath tusharmath left review comments

Assignees
No one assigned
Labels
🙋 Bounty claim state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. type: feature Brand new functionality, features, pages, workflows, endpoints, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a --watch feature
2 participants
@beelchester @tusharmath