-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(2639): implement entity resolver #2693
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2693 +/- ##
==========================================
+ Coverage 87.15% 87.83% +0.67%
==========================================
Files 253 263 +10
Lines 25585 26180 +595
==========================================
+ Hits 22299 22994 +695
+ Misses 3286 3186 -100 ☔ View full report in Codecov by Sentry. |
Action required: PR inactive for 5 days. |
Action required: PR inactive for 5 days. |
Action required: PR inactive for 5 days. |
Action required: PR inactive for 5 days. |
Summary:
Implements
Query._entities
handler according to the docPlease, note, I didn't add any special flags to the server and enable entity resolver if there any resolver on type. async_graphql enables the federation support either by flag or if the entity defined. docs
Caveats for current implementation:
@link
operator conflicts with apollo federation's@link
. To address this I'm disabling.add_directive(Link::directive_definition(generated_types))
in theconfig.rs
_service
handler. But the recommended approach from apollo is to load.graphql
schema file and we need to provide the definitions in that case somehowIssue Reference(s):
Fixes #2639
/claim #2639
Build & Testing:
cargo test
successfully../lint.sh --mode=fix
to fix all linting issues raised by./lint.sh --mode=check
.Checklist:
<type>(<optional scope>): <title>