-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(grpc): Load dependency proto files through reflection when available #2683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
type: fix
Iterations on existing features or infrastructure.
label
Aug 13, 2024
2 tasks
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2683 +/- ##
==========================================
+ Coverage 86.44% 86.47% +0.02%
==========================================
Files 255 255
Lines 24960 25030 +70
==========================================
+ Hits 21576 21644 +68
- Misses 3384 3386 +2 ☔ View full report in Codecov by Sentry. |
meskill
approved these changes
Aug 15, 2024
Co-authored-by: Kiryl Mialeshka <[email protected]>
Co-authored-by: Kiryl Mialeshka <[email protected]>
Hey, can we get a merge on this? |
tusharmath
approved these changes
Aug 17, 2024
tusharmath
approved these changes
Aug 17, 2024
beelchester
pushed a commit
to beelchester/tailcall
that referenced
this pull request
Aug 21, 2024
…ble (tailcallhq#2683) Co-authored-by: Kiryl Mialeshka <[email protected]> Co-authored-by: Tushar Mathur <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
When Tailcall links a reflection gRPC target, we can fetch all the dependencies using the reflection API.
Issue Reference(s):
Fixes #2678
Build & Testing:
cargo test
successfully../lint.sh --mode=fix
to fix all linting issues raised by./lint.sh --mode=check
.Checklist:
<type>(<optional scope>): <title>