Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(grpc): Load dependency proto files through reflection when available #2683

Merged
merged 11 commits into from
Aug 17, 2024

Conversation

karatakis
Copy link
Contributor

@karatakis karatakis commented Aug 13, 2024

Summary:
When Tailcall links a reflection gRPC target, we can fetch all the dependencies using the reflection API.

Issue Reference(s):
Fixes #2678

Build & Testing:

  • I ran cargo test successfully.
  • I have run ./lint.sh --mode=fix to fix all linting issues raised by ./lint.sh --mode=check.

Checklist:

  • I have added relevant unit & integration tests.
  • I have updated the documentation accordingly.
  • I have performed a self-review of my code.
  • PR follows the naming convention of <type>(<optional scope>): <title>

@github-actions github-actions bot added the type: fix Iterations on existing features or infrastructure. label Aug 13, 2024
Copy link

codecov bot commented Aug 14, 2024

Codecov Report

Attention: Patch coverage is 97.50000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 86.47%. Comparing base (2383d3b) to head (5e3837a).
Report is 1 commits behind head on main.

Files Patch % Lines
src/core/proto_reader/reader.rs 94.44% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2683      +/-   ##
==========================================
+ Coverage   86.44%   86.47%   +0.02%     
==========================================
  Files         255      255              
  Lines       24960    25030      +70     
==========================================
+ Hits        21576    21644      +68     
- Misses       3384     3386       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@karatakis karatakis marked this pull request as ready for review August 14, 2024 12:57
src/core/proto_reader/reader.rs Outdated Show resolved Hide resolved
src/core/proto_reader/reader.rs Outdated Show resolved Hide resolved
@BenNeighbour
Copy link

Hey, can we get a merge on this?

@tusharmath tusharmath enabled auto-merge (squash) August 17, 2024 07:11
@tusharmath tusharmath merged commit 12092ec into tailcallhq:main Aug 17, 2024
30 checks passed
@karatakis karatakis deleted the fix/issue-2678 branch August 19, 2024 08:52
beelchester pushed a commit to beelchester/tailcall that referenced this pull request Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: fix Iterations on existing features or infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gRPC with Multiple .proto files: : No such file or directory (os error 2)
4 participants