Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add deny_unknown_fields to nested structs #2666

Merged
merged 6 commits into from
Aug 12, 2024

Conversation

laststylebender14
Copy link
Contributor

@laststylebender14 laststylebender14 commented Aug 12, 2024

Summary:
Briefly describe the changes made in this PR.

Issue Reference(s):
Fixes #... (Replace "..." with the issue number)

Build & Testing:

  • I ran cargo test successfully.
  • I have run ./lint.sh --mode=fix to fix all linting issues raised by ./lint.sh --mode=check.

Checklist:

  • I have added relevant unit & integration tests.
  • I have updated the documentation accordingly.
  • I have performed a self-review of my code.
  • PR follows the naming convention of <type>(<optional scope>): <title>

@laststylebender14 laststylebender14 marked this pull request as draft August 12, 2024 06:40
@github-actions github-actions bot added the type: fix Iterations on existing features or infrastructure. label Aug 12, 2024
Copy link

codecov bot commented Aug 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.53%. Comparing base (e6b3688) to head (17b6827).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2666      +/-   ##
==========================================
+ Coverage   86.49%   86.53%   +0.03%     
==========================================
  Files         252      252              
  Lines       24283    24353      +70     
==========================================
+ Hits        21003    21073      +70     
  Misses       3280     3280              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@laststylebender14 laststylebender14 marked this pull request as ready for review August 12, 2024 06:55
@tusharmath tusharmath enabled auto-merge (squash) August 12, 2024 11:11
@tusharmath tusharmath merged commit 5d3f1ad into main Aug 12, 2024
36 checks passed
@tusharmath tusharmath deleted the fix/add-deny_unknown_fields-to-all-structs branch August 12, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: fix Iterations on existing features or infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants