feat(2654): process secret in config #2656
Conversation
github-actions
bot
added
the
type: feature
src/cli/generator/config.rs
Outdated
src/cli/generator/config.rs
Outdated
| @@ -23,6 +23,8 @@ pub struct Config<Status = UnResolved> { | |||
| #[serde(skip_serializing_if = "Option::is_none")] | |||
| pub preset: Option<PresetConfig>, | |||
| pub schema: Schema, | |||
| #[serde(skip_serializing_if = "Option::is_none")] | |||
| pub secret: Option<String>, | |||
There was a problem hiding this comment.
Need to abstract this out using a NewType
There was a problem hiding this comment.
created new Secret type now
There was a problem hiding this comment.
Instead of using String use
struct TemplateString(Mustache);Implement it's serde so that you can simply plug and play TemplateString at the time of deserialization instead of introducing an additional step.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2656 +/- ##
==========================================
- Coverage 86.48% 85.91% -0.57%
==========================================
Files 252 252
Lines 24291 24331 +40
==========================================
- Hits 21009 20905 -104
- Misses 3282 3426 +144 ☔ View full report in Codecov by Sentry. |
|
Moving to draft to reduce noise and improve CI efficiency. Once you are ready just mark it as "ready to review". Feel free to give a shoutout on the #contributors channel on Discord if you want immediate attention. |
dekkku
changed the title
…/tailcall into feat/add-secret-to-config
Summary:
Briefly describe the changes made in this PR.
Issue Reference(s):
Fixes #2654
/claim #2654
Build & Testing:
cargo testsuccessfully../lint.sh --mode=fixto fix all linting issues raised by./lint.sh --mode=check.Checklist:
<type>(<optional scope>): <title>