Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: recursive types on @graphql directive #2528

Merged
merged 2 commits into from
Jul 25, 2024

Conversation

ssddOnTop
Copy link
Member

Issue Reference(s):
Fixes #2525

@ssddOnTop ssddOnTop changed the title chore: fix recursive types on `@graphql directive chore: fix recursive types on @graphql directive Jul 25, 2024
@github-actions github-actions bot added type: chore Routine tasks like conversions, reorganization, and maintenance work. type: fix Iterations on existing features or infrastructure. labels Jul 25, 2024
@ssddOnTop ssddOnTop changed the title chore: fix recursive types on @graphql directive fix: recursive types on @graphql directive Jul 25, 2024
@ssddOnTop ssddOnTop removed the type: chore Routine tasks like conversions, reorganization, and maintenance work. label Jul 25, 2024
Copy link
Contributor

@karatakis karatakis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Copy link

codecov bot commented Jul 25, 2024

Codecov Report

Attention: Patch coverage is 93.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 87.35%. Comparing base (81bbb1a) to head (3139e27).

Files Patch % Lines
src/core/blueprint/operators/graphql.rs 93.33% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2528   +/-   ##
=======================================
  Coverage   87.35%   87.35%           
=======================================
  Files         237      237           
  Lines       23787    23798   +11     
=======================================
+ Hits        20778    20789   +11     
  Misses       3009     3009           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tusharmath
Copy link
Contributor

@ouertani can you check if this is working?

@ouertani
Copy link
Contributor

@ouertani can you check if this is working?

This fixes the base use case thank you for fast response. For a bigger schema still facing the issue where the start sleep indefinitely. I'm trying to find and formulate the bigger case.

@tusharmath
Copy link
Contributor

/tip $50

@tusharmath tusharmath merged commit 89e021b into main Jul 25, 2024
35 checks passed
@tusharmath tusharmath deleted the chore/fix-stackoverflow-related-fields branch July 25, 2024 16:08
Copy link

algora-pbc bot commented Jul 25, 2024

🎉🎈 @ssddOnTop has been awarded $50! 🎈🎊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💰 Rewarded type: fix Iterations on existing features or infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Recursive nodes
4 participants